Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1509373005: do not suggest import uri reaching out of lib (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-09 19:00:06 UTC) #2
scheglov
LGTM
5 years ago (2015-12-09 19:32:50 UTC) #3
danrubel
5 years ago (2015-12-09 19:38:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d54fb071a931042f5d5689c4a34b202ce0fdd4db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698