Pass method parameters as JavaParamRef in chrome/browser (part 2).

chrome/browser/interests/android/interests_service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/interests/android/interests_service.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
@@ skipping 33 matching lines @@
   return j_interests;
 }
 
 }  // namespace
 
 InterestsService::InterestsService(Profile* profile)
     : profile_(profile), weak_ptr_factory_(this) {}
 
 InterestsService::~InterestsService() {}
 
-void InterestsService::Destroy(JNIEnv* env, jobject obj) {
+void InterestsService::Destroy(JNIEnv* env, const JavaParamRef<jobject>& obj) {

[Marc Treib, 2015/12/10 08:37:17]

Don't you need a
using base::android::JavaParamRef;
at the top of this file?

[Torne, 2015/12/10 11:26:01]

All the generated jni/*_jni.h headers already use these types without the
namespace, and include jni_generator_helper.h, which has a using declaration for
ScopedJavaLocalRef and JavaParamRef (the types used in JNI bound functions).
This probably isn't the best style, but many .cc files throughout the codebase
already relied on it before I started this work, and I didn't think about it too
much at the time :/

If I changed the generator to output the full namespace I could remove the using
directive from the header file and go through and fix all the .cc files to do it
themselves - if people think this is worth doing I can file a bug to track doing
that later once I've been able to land all the parts of the migration I'm
already in the middle of.

[Marc Treib, 2015/12/10 11:46:02]

Thanks for the explanation!
The generated *_jni.h headers should only ever get included in .cc files, so I
guess that's kinda sorta okay.
Hm, not sure if that's worth the hassle. I certainly won't pressure you to do
it. :)

   delete this;
 }
 
-void InterestsService::GetInterests(JNIEnv* env,
-                                    jobject obj,
-                                    jobject j_callback_obj) {
+void InterestsService::GetInterests(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj,
+    const JavaParamRef<jobject>& j_callback_obj) {
   ScopedJavaGlobalRef<jobject> j_callback(env, j_callback_obj);
 
   scoped_ptr<InterestsFetcher> fetcher =
       InterestsFetcher::CreateFromProfile(profile_);
   InterestsFetcher* fetcher_raw_ptr = fetcher.get();
 
   InterestsFetcher::InterestsCallback callback = base::Bind(
       &InterestsService::OnObtainedInterests,
       weak_ptr_factory_.GetWeakPtr(),
       base::Passed(fetcher.Pass()),
@@ skipping 19 matching lines @@
                                                          j_interests.obj());
 }
 
 static jlong Init(JNIEnv* env,
                   const JavaParamRef<jobject>& jobj,
                   const JavaParamRef<jobject>& jprofile) {
   InterestsService* interests_service =
       new InterestsService(ProfileAndroid::FromProfileAndroid(jprofile));
   return reinterpret_cast<intptr_t>(interests_service);
 }