Pass method parameters as JavaParamRef in chrome/browser (part 2).

chrome/browser/autofill/android/personal_data_manager_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/android/personal_data_manager_android.h"
 
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/command_line.h"
 #include "base/format_macros.h"
@@ skipping 151 matching lines @@
     : weak_java_obj_(env, obj),
       personal_data_manager_(PersonalDataManagerFactory::GetForProfile(
           ProfileManager::GetActiveUserProfile())) {
   personal_data_manager_->AddObserver(this);
 }
 
 PersonalDataManagerAndroid::~PersonalDataManagerAndroid() {
   personal_data_manager_->RemoveObserver(this);
 }
 
-jint PersonalDataManagerAndroid::GetProfileCount(JNIEnv* unused_env,
-                                                 jobject unused_obj) {
+jint PersonalDataManagerAndroid::GetProfileCount(
+    JNIEnv* unused_env,
+    const JavaParamRef<jobject>& unused_obj) {
   return personal_data_manager_->GetProfiles().size();
 }
 
 ScopedJavaLocalRef<jobject> PersonalDataManagerAndroid::GetProfileByIndex(
     JNIEnv* env,
-    jobject unused_obj,
+    const JavaParamRef<jobject>& unused_obj,
     jint index) {
   const std::vector<AutofillProfile*>& profiles =
       personal_data_manager_->GetProfiles();
   size_t index_size_t = static_cast<size_t>(index);
   DCHECK_LT(index_size_t, profiles.size());
   return CreateJavaProfileFromNative(env, *profiles[index_size_t]);
 }
 
 ScopedJavaLocalRef<jobject> PersonalDataManagerAndroid::GetProfileByGUID(
     JNIEnv* env,
-    jobject unused_obj,
-    jstring jguid) {
+    const JavaParamRef<jobject>& unused_obj,
+    const JavaParamRef<jstring>& jguid) {
   AutofillProfile* profile = personal_data_manager_->GetProfileByGUID(
       ConvertJavaStringToUTF8(env, jguid));
   if (!profile)
     return ScopedJavaLocalRef<jobject>();
 
   return CreateJavaProfileFromNative(env, *profile);
 }
 
 ScopedJavaLocalRef<jstring> PersonalDataManagerAndroid::SetProfile(
     JNIEnv* env,
-    jobject unused_obj,
-    jobject jprofile) {
+    const JavaParamRef<jobject>& unused_obj,
+    const JavaParamRef<jobject>& jprofile) {
   std::string guid = ConvertJavaStringToUTF8(
       env,
       Java_AutofillProfile_getGUID(env, jprofile).obj());
 
   AutofillProfile profile;
   PopulateNativeProfileFromJava(jprofile, env, &profile);
 
   if (guid.empty()) {
     personal_data_manager_->AddProfile(profile);
   } else {
     profile.set_guid(guid);
     personal_data_manager_->UpdateProfile(profile);
   }
 
   return ConvertUTF8ToJavaString(env, profile.guid());
 }
 
 ScopedJavaLocalRef<jobjectArray> PersonalDataManagerAndroid::GetProfileLabels(
     JNIEnv* env,
-    jobject unused_obj) {
+    const JavaParamRef<jobject>& unused_obj) {
   std::vector<base::string16> labels;
   AutofillProfile::CreateInferredLabels(
       personal_data_manager_->GetProfiles(), NULL, NAME_FULL, 2,
       g_browser_process->GetApplicationLocale(), &labels);
 
   return base::android::ToJavaArrayOfStrings(env, labels);
 }
 
-jint PersonalDataManagerAndroid::GetCreditCardCount(JNIEnv* unused_env,
-                                                    jobject unused_obj) {
+jint PersonalDataManagerAndroid::GetCreditCardCount(
+    JNIEnv* unused_env,
+    const JavaParamRef<jobject>& unused_obj) {
   return personal_data_manager_->GetCreditCards().size();
 }
 
 ScopedJavaLocalRef<jobject> PersonalDataManagerAndroid::GetCreditCardByIndex(
     JNIEnv* env,
-    jobject unused_obj,
+    const JavaParamRef<jobject>& unused_obj,
     jint index) {
   const std::vector<CreditCard*>& credit_cards =
       personal_data_manager_->GetCreditCards();
   size_t index_size_t = static_cast<size_t>(index);
   DCHECK_LT(index_size_t, credit_cards.size());
   return CreateJavaCreditCardFromNative(env, *credit_cards[index_size_t]);
 }
 
 ScopedJavaLocalRef<jobject> PersonalDataManagerAndroid::GetCreditCardByGUID(
     JNIEnv* env,
-    jobject unused_obj,
-    jstring jguid) {
+    const JavaParamRef<jobject>& unused_obj,
+    const JavaParamRef<jstring>& jguid) {
   CreditCard* card = personal_data_manager_->GetCreditCardByGUID(
           ConvertJavaStringToUTF8(env, jguid));
   if (!card)
     return ScopedJavaLocalRef<jobject>();
 
   return CreateJavaCreditCardFromNative(env, *card);
 }
 
 ScopedJavaLocalRef<jstring> PersonalDataManagerAndroid::SetCreditCard(
     JNIEnv* env,
-    jobject unused_obj,
-    jobject jcard) {
+    const JavaParamRef<jobject>& unused_obj,
+    const JavaParamRef<jobject>& jcard) {
   std::string guid = ConvertJavaStringToUTF8(
        env,
        Java_CreditCard_getGUID(env, jcard).obj());
 
   CreditCard card;
   PopulateNativeCreditCardFromJava(jcard, env, &card);
 
   if (guid.empty()) {
     personal_data_manager_->AddCreditCard(card);
   } else {
     card.set_guid(guid);
     personal_data_manager_->UpdateCreditCard(card);
   }
   return ConvertUTF8ToJavaString(env, card.guid());
 }
 
-void PersonalDataManagerAndroid::RemoveByGUID(JNIEnv* env,
-                                              jobject unused_obj,
-                                              jstring jguid) {
+void PersonalDataManagerAndroid::RemoveByGUID(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& unused_obj,
+    const JavaParamRef<jstring>& jguid) {
   personal_data_manager_->RemoveByGUID(ConvertJavaStringToUTF8(env, jguid));
 }
 
-void PersonalDataManagerAndroid::ClearUnmaskedCache(JNIEnv* env,
-                                                    jobject unused_obj,
-                                                    jstring guid) {
+void PersonalDataManagerAndroid::ClearUnmaskedCache(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& unused_obj,
+    const JavaParamRef<jstring>& guid) {
   personal_data_manager_->ResetFullServerCard(
       ConvertJavaStringToUTF8(env, guid));
 }
 
 void PersonalDataManagerAndroid::OnPersonalDataChanged() {
   JNIEnv* env = base::android::AttachCurrentThread();
   if (weak_java_obj_.get(env).is_null())
     return;
 
   Java_PersonalDataManager_personalDataChanged(env,
@@ skipping 56 matching lines @@
                g_browser_process->GetApplicationLocale()));
 }
 
 static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   PersonalDataManagerAndroid* personal_data_manager_android =
       new PersonalDataManagerAndroid(env, obj);
   return reinterpret_cast<intptr_t>(personal_data_manager_android);
 }
 
 }  // namespace autofill