Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1509353004: Add UseCounters for Selection methods that take null (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
CC:
chromium-reviews, blink-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounters for Selection methods that take null Making collapse's argument non-nullable appears risky: https://codereview.chromium.org/1498253002/#msg9 The risk for setBaseAndExtent is entirely unknown. Measure both cases before proceeding further. The change to Selection.idl is for clarity only, these are implicitly nullable because of [LegacyInterfaceTypeChecking], and adding making them explicitly nullable does not change the generated code. Committed: https://crrev.com/a1d16968955b0957078049434f840b4b7fc64023 Cr-Commit-Position: refs/heads/master@{#364344}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/Selection/use-counters.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Selection.idl View 1 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509353004/1
5 years ago (2015-12-09 11:16:58 UTC) #2
philipj_slow
PTAL
5 years ago (2015-12-09 12:54:02 UTC) #4
haraken
LGTM
5 years ago (2015-12-09 13:57:46 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-09 14:58:38 UTC) #7
Ilya Sherman
histograms.xml lgtm
5 years ago (2015-12-09 23:14:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509353004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509353004/20001
5 years ago (2015-12-10 10:10:08 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 12:46:28 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-10 12:47:33 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a1d16968955b0957078049434f840b4b7fc64023
Cr-Commit-Position: refs/heads/master@{#364344}

Powered by Google App Engine
This is Rietveld 408576698