mojo/services/media/common/interfaces/media_state.mojom - Issue 1509323002: Mojom updates for Motown.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/services/media/common/interfaces/media_state.mojom

Issue 1509323002: Mojom updates for Motown. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« mojo/services/media/common/interfaces/media_metadata.mojom ('K') | « mojo/services/media/common/interfaces/media_pipe.mojom ('k') | mojo/services/media/common/interfaces/media_transport.mojom » ('j') | mojo/services/media/common/interfaces/media_types.mojom » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [DartPackage="mojo_services"]

	6 module mojo.media;

	7

	8 // Expresses the overall state of a media component.

	9 enum MediaState {

	10 // Unable to function due to error. Fault details are provided elsewhere.

	11 FAULT,

	12

	13 // Intentionally disabled.

	14 DISABLED,

	15

	16 // Requires preparation in order to function.

	17 UNPREPARED,

	18

	19 // Preparation underway.

	20 PREPARING,

	21

	22 // Fully prepared, rate zero (paused).

	23 PREPARED,

	24

	25 // Fully prepared, rate non-zero.

	26 PLAYING,
	johngro 2015/12/10 21:46:02 design question; we can defer action on this until design question; we can defer action on this until later. Should we be exposing clock concepts here? What state do we go to if we were playing and we pause, is that back to prepared? How about a live stream? Once it is buffered, do we stay in prepared but discard stale data until we start to play? Perhaps PREPARED and PLAYING can be merged into just READY. We could introduce a separate BUFFERING state which we could transition to in an underflow/re-buffer scenario, but we could also just bounce back and forth between READY and PREPARING if we didn't want a separate state. dalesat 2015/12/10 22:33:38 Many good questions. I've renamed PREPARED -> PAUS Show quoted text On 2015/12/10 21:46:02, johngro wrote: > design question; we can defer action on this until later. > > Should we be exposing clock concepts here? What state do we go to if we were > playing and we pause, is that back to prepared? How about a live stream? Once > it is buffered, do we stay in prepared but discard stale data until we start to > play? > > Perhaps PREPARED and PLAYING can be merged into just READY. We could introduce > a separate BUFFERING state which we could transition to in an > underflow/re-buffer scenario, but we could also just bounce back and forth > between READY and PREPARING if we didn't want a separate state. Many good questions. I've renamed PREPARED -> PAUSED. There are many ways to go with respect to factoring state. For now, I wanted something simple that would drive UI in a straightforward manner.
	27

	28 // Stopped playing because end-of-stream was encountered.

	29 ENDED

	30 };

OLD	NEW