Reland "Unifies ScrollView and RenderLayer to use non-shi..."

Reland "Unifies ScrollView and RenderLayer to use non-shi..."

DO NOT REVERT THIS if AutomationRendererHelperTest.RTLSnapshot fails when
blink is rolled. A chromium patch is reviewed and ready for dcommit.
https://chromiumcodereview.appspot.com/15006004/

> Unifies ScrollView and RenderLayer to use non-shifted [minPos, maxPos] scroll offset
> 
> For pages with negative overflow (due to RTL or writing mode), there are
> two sets of scroll offset defined. One that ranges from [0, maxPos - minPos]
> and the other one ranges from [minPos, maxPos]. To reduce confusion, this
> patch unifies ScrollView and RenderLayer to use the second definition of
> scroll offset.
> 
> BUG=232063
> TEST=manual
> R=jamesr@chromium.org,jchaffraix@chromium.org
> 
> Review URL: https://chromiumcodereview.appspot.com/14807003

TBR=jamesr@chromium.org,jchaffraix@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150264

[trchen, 2013-05-13 21:36:59]

Committed patchset #1 manually as r150264 (presubmit successful).

[danakj, 2013-05-13 21:38:40]

Can you just disable the test until this rolls over? The blink waterfall
will go red immediately otherwise.
On May 13, 2013 5:37 PM, <trchen@chromium.org> wrote:

> Reviewers: jamesr, Julien Chaffraix,
>
> Message:
> Committed patchset #1 manually as r150264 (presubmit successful).
>
> Description:
> Reland "Unifies ScrollView and RenderLayer to use non-shi..."
>
> DO NOT REVERT THIS if AutomationRendererHelperTest.**RTLSnapshot fails
> when
> blink is rolled. A chromium patch is reviewed and ready for dcommit.
>
https://chromiumcodereview.**appspot.com/15006004/<https://chromiumcodereview...
>
>  Unifies ScrollView and RenderLayer to use non-shifted [minPos, maxPos]
>> scroll
>>
> offset
>
>  For pages with negative overflow (due to RTL or writing mode), there are
>> two sets of scroll offset defined. One that ranges from [0, maxPos -
>> minPos]
>> and the other one ranges from [minPos, maxPos]. To reduce confusion, this
>> patch unifies ScrollView and RenderLayer to use the second definition of
>> scroll offset.
>>
>
>  BUG=232063
>> TEST=manual
>> R=jamesr@chromium.org,jchaffra**ix@chromium.org <jchaffraix@chromium.org>
>>
>
>  Review URL:
https://chromiumcodereview.**appspot.com/14807003<https://chromiumcodereview....
>>
>
> TBR=jamesr@chromium.org,jchaff**raix@chromium.org<jchaffraix@chromium.org>
>
> Committed: https://src.chromium.org/**viewvc/blink?view=rev&**
>
revision=150264<https://src.chromium.org/viewvc/blink?view=rev&revision=150264>
>
> Please review this at
https://codereview.chromium.**org/15093011/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/blink/**trunk<http://svn.chromium.org/blink/trunk>
>
> Affected files:
>   M LayoutTests/TestExpectations
>   M LayoutTests/compositing/**overflow/composited-scrolling-**
> creates-a-stacking-container-**expected.txt
>   M LayoutTests/compositing/**overflow/composited-scrolling-**
> paint-phases-expected.txt
>   M LayoutTests/compositing/**overflow/scrolling-content-**
> clip-to-viewport-expected.txt
>   M LayoutTests/compositing/**overflow/scrolling-without-**
> painting-expected.txt
>   M LayoutTests/compositing/**overflow/textarea-scroll-**
> touch-expected.txt
>   M LayoutTests/compositing/**overflow/updating-scrolling-**
> content-expected.txt
>   M LayoutTests/fast/multicol/**shrink-to-column-height-for-**
> pagination.html
>   M LayoutTests/platform/chromium-**linux/compositing/overflow/**
> scrolling-without-painting-**expected.txt
>   M LayoutTests/platform/chromium-**linux/compositing/overflow/**
> updating-scrolling-content-**expected.txt
>   M LayoutTests/platform/chromium-**linux/virtual/gpu/**
> compositedscrolling/overflow/**scrolling-content-clip-to-**
> viewport-expected.txt
>   M LayoutTests/platform/chromium-**linux/virtual/gpu/**
> compositedscrolling/overflow/**scrolling-without-painting-**expected.txt
>   M LayoutTests/platform/chromium-**linux/virtual/gpu/**
> compositedscrolling/overflow/**updating-scrolling-content-**expected.txt
>   M LayoutTests/platform/chromium-**linux/virtual/**
> softwarecompositing/overflow/**scrolling-content-clip-to-**
> viewport-expected.txt
>   M LayoutTests/platform/chromium-**linux/virtual/**
> softwarecompositing/overflow/**scrolling-without-painting-**expected.txt
>   M LayoutTests/platform/chromium-**linux/virtual/**
> softwarecompositing/overflow/**updating-scrolling-content-**expected.txt
>   M LayoutTests/platform/chromium-**mac/compositing/overflow/**
> textarea-scroll-touch-**expected.txt
>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
> composited-scrolling-creates-**a-stacking-container-expected.**txt
>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
> composited-scrolling-paint-**phases-expected.txt
>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
> overflow-auto-with-touch-**expected.txt
>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
> overflow-auto-with-touch-**toggle-expected.txt
>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
> scrolling-without-painting-**expected.txt
>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
> updating-scrolling-content-**expected.txt
>   M LayoutTests/virtual/**softwarecompositing/overflow/**
> composited-scrolling-creates-**a-stacking-container-expected.**txt
>   M LayoutTests/virtual/**softwarecompositing/overflow/**
> composited-scrolling-paint-**phases-expected.txt
>   M LayoutTests/virtual/**softwarecompositing/overflow/**
> scrolling-without-painting-**expected.txt
>   M LayoutTests/virtual/**softwarecompositing/overflow/**
> updating-scrolling-content-**expected.txt
>   M Source/WebKit/chromium/tests/**ScrollAnimatorNoneTest.cpp
>   M Source/core/platform/**ScrollAnimator.cpp
>   M Source/core/platform/**ScrollView.cpp
>   M Source/core/platform/**ScrollableArea.h
>   M Source/core/platform/**Scrollbar.cpp
>   M Source/core/platform/graphics/**chromium/**GraphicsLayerChromium.cpp
>   M Source/core/platform/mac/**ScrollAnimatorMac.mm
>   M Source/core/rendering/**RenderLayer.h
>   M Source/core/rendering/**RenderLayer.cpp
>   M Source/core/rendering/**RenderLayerBacking.cpp
>
>
>

[trchen, 2013-05-13 21:41:22]

Do we always disable test then re-enable when doing two-sided patch?

On Mon, May 13, 2013 at 2:38 PM, Dana Jansens <danakj@chromium.org> wrote:

> Can you just disable the test until this rolls over? The blink waterfall
> will go red immediately otherwise.
> On May 13, 2013 5:37 PM, <trchen@chromium.org> wrote:
>
>> Reviewers: jamesr, Julien Chaffraix,
>>
>> Message:
>> Committed patchset #1 manually as r150264 (presubmit successful).
>>
>> Description:
>> Reland "Unifies ScrollView and RenderLayer to use non-shi..."
>>
>> DO NOT REVERT THIS if AutomationRendererHelperTest.**RTLSnapshot fails
>> when
>> blink is rolled. A chromium patch is reviewed and ready for dcommit.
>>
https://chromiumcodereview.**appspot.com/15006004/<https://chromiumcodereview...
>>
>>  Unifies ScrollView and RenderLayer to use non-shifted [minPos, maxPos]
>>> scroll
>>>
>> offset
>>
>>  For pages with negative overflow (due to RTL or writing mode), there are
>>> two sets of scroll offset defined. One that ranges from [0, maxPos -
>>> minPos]
>>> and the other one ranges from [minPos, maxPos]. To reduce confusion, this
>>> patch unifies ScrollView and RenderLayer to use the second definition of
>>> scroll offset.
>>>
>>
>>  BUG=232063
>>> TEST=manual
>>> R=jamesr@chromium.org,jchaffra**ix@chromium.org<jchaffraix@chromium.org>
>>>
>>
>>  Review URL:
https://chromiumcodereview.**appspot.com/14807003<https://chromiumcodereview....
>>>
>>
>> TBR=jamesr@chromium.org,jchaff**raix@chromium.org<jchaffraix@chromium.org>
>>
>> Committed: https://src.chromium.org/**viewvc/blink?view=rev&**
>>
revision=150264<https://src.chromium.org/viewvc/blink?view=rev&revision=150264>
>>
>> Please review this at
https://codereview.chromium.**org/15093011/<https://codereview.chromium.org/1...
>>
>> SVN Base:
svn://svn.chromium.org/blink/**trunk<http://svn.chromium.org/blink/trunk>
>>
>> Affected files:
>>   M LayoutTests/TestExpectations
>>   M LayoutTests/compositing/**overflow/composited-scrolling-**
>> creates-a-stacking-container-**expected.txt
>>   M LayoutTests/compositing/**overflow/composited-scrolling-**
>> paint-phases-expected.txt
>>   M LayoutTests/compositing/**overflow/scrolling-content-**
>> clip-to-viewport-expected.txt
>>   M LayoutTests/compositing/**overflow/scrolling-without-**
>> painting-expected.txt
>>   M LayoutTests/compositing/**overflow/textarea-scroll-**
>> touch-expected.txt
>>   M LayoutTests/compositing/**overflow/updating-scrolling-**
>> content-expected.txt
>>   M LayoutTests/fast/multicol/**shrink-to-column-height-for-**
>> pagination.html
>>   M LayoutTests/platform/chromium-**linux/compositing/overflow/**
>> scrolling-without-painting-**expected.txt
>>   M LayoutTests/platform/chromium-**linux/compositing/overflow/**
>> updating-scrolling-content-**expected.txt
>>   M LayoutTests/platform/chromium-**linux/virtual/gpu/**
>> compositedscrolling/overflow/**scrolling-content-clip-to-**
>> viewport-expected.txt
>>   M LayoutTests/platform/chromium-**linux/virtual/gpu/**
>> compositedscrolling/overflow/**scrolling-without-painting-**expected.txt
>>   M LayoutTests/platform/chromium-**linux/virtual/gpu/**
>> compositedscrolling/overflow/**updating-scrolling-content-**expected.txt
>>   M LayoutTests/platform/chromium-**linux/virtual/**
>> softwarecompositing/overflow/**scrolling-content-clip-to-**
>> viewport-expected.txt
>>   M LayoutTests/platform/chromium-**linux/virtual/**
>> softwarecompositing/overflow/**scrolling-without-painting-**expected.txt
>>   M LayoutTests/platform/chromium-**linux/virtual/**
>> softwarecompositing/overflow/**updating-scrolling-content-**expected.txt
>>   M LayoutTests/platform/chromium-**mac/compositing/overflow/**
>> textarea-scroll-touch-**expected.txt
>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>> composited-scrolling-creates-**a-stacking-container-expected.**txt
>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>> composited-scrolling-paint-**phases-expected.txt
>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>> overflow-auto-with-touch-**expected.txt
>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>> overflow-auto-with-touch-**toggle-expected.txt
>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>> scrolling-without-painting-**expected.txt
>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>> updating-scrolling-content-**expected.txt
>>   M LayoutTests/virtual/**softwarecompositing/overflow/**
>> composited-scrolling-creates-**a-stacking-container-expected.**txt
>>   M LayoutTests/virtual/**softwarecompositing/overflow/**
>> composited-scrolling-paint-**phases-expected.txt
>>   M LayoutTests/virtual/**softwarecompositing/overflow/**
>> scrolling-without-painting-**expected.txt
>>   M LayoutTests/virtual/**softwarecompositing/overflow/**
>> updating-scrolling-content-**expected.txt
>>   M Source/WebKit/chromium/tests/**ScrollAnimatorNoneTest.cpp
>>   M Source/core/platform/**ScrollAnimator.cpp
>>   M Source/core/platform/**ScrollView.cpp
>>   M Source/core/platform/**ScrollableArea.h
>>   M Source/core/platform/**Scrollbar.cpp
>>   M Source/core/platform/graphics/**chromium/**GraphicsLayerChromium.cpp
>>   M Source/core/platform/mac/**ScrollAnimatorMac.mm
>>   M Source/core/rendering/**RenderLayer.h
>>   M Source/core/rendering/**RenderLayer.cpp
>>   M Source/core/rendering/**RenderLayerBacking.cpp
>>
>>
>>

[trchen, 2013-05-14 00:39:56]

Okay I disabled the test just now. Will re-enable along with the chromium
patch.
Today doesn't seem like a good day to introduce more redness. :/

On Mon, May 13, 2013 at 2:38 PM, Dana Jansens <danakj@chromium.org> wrote:

> Can you just disable the test until this rolls over? The blink waterfall
> will go red immediately otherwise.
> On May 13, 2013 5:37 PM, <trchen@chromium.org> wrote:
>
>> Reviewers: jamesr, Julien Chaffraix,
>>
>> Message:
>> Committed patchset #1 manually as r150264 (presubmit successful).
>>
>> Description:
>> Reland "Unifies ScrollView and RenderLayer to use non-shi..."
>>
>> DO NOT REVERT THIS if AutomationRendererHelperTest.**RTLSnapshot fails
>> when
>> blink is rolled. A chromium patch is reviewed and ready for dcommit.
>>
https://chromiumcodereview.**appspot.com/15006004/<https://chromiumcodereview...
>>
>>  Unifies ScrollView and RenderLayer to use non-shifted [minPos, maxPos]
>>> scroll
>>>
>> offset
>>
>>  For pages with negative overflow (due to RTL or writing mode), there are
>>> two sets of scroll offset defined. One that ranges from [0, maxPos -
>>> minPos]
>>> and the other one ranges from [minPos, maxPos]. To reduce confusion, this
>>> patch unifies ScrollView and RenderLayer to use the second definition of
>>> scroll offset.
>>>
>>
>>  BUG=232063
>>> TEST=manual
>>> R=jamesr@chromium.org,jchaffra**ix@chromium.org<jchaffraix@chromium.org>
>>>
>>
>>  Review URL:
https://chromiumcodereview.**appspot.com/14807003<https://chromiumcodereview....
>>>
>>
>> TBR=jamesr@chromium.org,jchaff**raix@chromium.org<jchaffraix@chromium.org>
>>
>> Committed: https://src.chromium.org/**viewvc/blink?view=rev&**
>>
revision=150264<https://src.chromium.org/viewvc/blink?view=rev&revision=150264>
>>
>> Please review this at
https://codereview.chromium.**org/15093011/<https://codereview.chromium.org/1...
>>
>> SVN Base:
svn://svn.chromium.org/blink/**trunk<http://svn.chromium.org/blink/trunk>
>>
>> Affected files:
>>   M LayoutTests/TestExpectations
>>   M LayoutTests/compositing/**overflow/composited-scrolling-**
>> creates-a-stacking-container-**expected.txt
>>   M LayoutTests/compositing/**overflow/composited-scrolling-**
>> paint-phases-expected.txt
>>   M LayoutTests/compositing/**overflow/scrolling-content-**
>> clip-to-viewport-expected.txt
>>   M LayoutTests/compositing/**overflow/scrolling-without-**
>> painting-expected.txt
>>   M LayoutTests/compositing/**overflow/textarea-scroll-**
>> touch-expected.txt
>>   M LayoutTests/compositing/**overflow/updating-scrolling-**
>> content-expected.txt
>>   M LayoutTests/fast/multicol/**shrink-to-column-height-for-**
>> pagination.html
>>   M LayoutTests/platform/chromium-**linux/compositing/overflow/**
>> scrolling-without-painting-**expected.txt
>>   M LayoutTests/platform/chromium-**linux/compositing/overflow/**
>> updating-scrolling-content-**expected.txt
>>   M LayoutTests/platform/chromium-**linux/virtual/gpu/**
>> compositedscrolling/overflow/**scrolling-content-clip-to-**
>> viewport-expected.txt
>>   M LayoutTests/platform/chromium-**linux/virtual/gpu/**
>> compositedscrolling/overflow/**scrolling-without-painting-**expected.txt
>>   M LayoutTests/platform/chromium-**linux/virtual/gpu/**
>> compositedscrolling/overflow/**updating-scrolling-content-**expected.txt
>>   M LayoutTests/platform/chromium-**linux/virtual/**
>> softwarecompositing/overflow/**scrolling-content-clip-to-**
>> viewport-expected.txt
>>   M LayoutTests/platform/chromium-**linux/virtual/**
>> softwarecompositing/overflow/**scrolling-without-painting-**expected.txt
>>   M LayoutTests/platform/chromium-**linux/virtual/**
>> softwarecompositing/overflow/**updating-scrolling-content-**expected.txt
>>   M LayoutTests/platform/chromium-**mac/compositing/overflow/**
>> textarea-scroll-touch-**expected.txt
>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>> composited-scrolling-creates-**a-stacking-container-expected.**txt
>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>> composited-scrolling-paint-**phases-expected.txt
>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>> overflow-auto-with-touch-**expected.txt
>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>> overflow-auto-with-touch-**toggle-expected.txt
>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>> scrolling-without-painting-**expected.txt
>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>> updating-scrolling-content-**expected.txt
>>   M LayoutTests/virtual/**softwarecompositing/overflow/**
>> composited-scrolling-creates-**a-stacking-container-expected.**txt
>>   M LayoutTests/virtual/**softwarecompositing/overflow/**
>> composited-scrolling-paint-**phases-expected.txt
>>   M LayoutTests/virtual/**softwarecompositing/overflow/**
>> scrolling-without-painting-**expected.txt
>>   M LayoutTests/virtual/**softwarecompositing/overflow/**
>> updating-scrolling-content-**expected.txt
>>   M Source/WebKit/chromium/tests/**ScrollAnimatorNoneTest.cpp
>>   M Source/core/platform/**ScrollAnimator.cpp
>>   M Source/core/platform/**ScrollView.cpp
>>   M Source/core/platform/**ScrollableArea.h
>>   M Source/core/platform/**Scrollbar.cpp
>>   M Source/core/platform/graphics/**chromium/**GraphicsLayerChromium.cpp
>>   M Source/core/platform/mac/**ScrollAnimatorMac.mm
>>   M Source/core/rendering/**RenderLayer.h
>>   M Source/core/rendering/**RenderLayer.cpp
>>   M Source/core/rendering/**RenderLayerBacking.cpp
>>
>>
>>

[danakj, 2013-05-14 13:33:38]

On Mon, May 13, 2013 at 5:41 PM, Tien-Ren Chen <trchen@chromium.org> wrote:

> Do we always disable test then re-enable when doing two-sided patch?
>

We always use ifdefs of some sort to prevent redness/breakage. Often it's a
case of ifdefing out the new code then having the blink roll activate it.
Disabling a test is a more blunt approach than this, but for a single test
it's not unreasonable IMO.


>
> On Mon, May 13, 2013 at 2:38 PM, Dana Jansens <danakj@chromium.org> wrote:
>
>> Can you just disable the test until this rolls over? The blink waterfall
>> will go red immediately otherwise.
>>  On May 13, 2013 5:37 PM, <trchen@chromium.org> wrote:
>>
>>> Reviewers: jamesr, Julien Chaffraix,
>>>
>>> Message:
>>> Committed patchset #1 manually as r150264 (presubmit successful).
>>>
>>> Description:
>>> Reland "Unifies ScrollView and RenderLayer to use non-shi..."
>>>
>>> DO NOT REVERT THIS if AutomationRendererHelperTest.**RTLSnapshot fails
>>> when
>>> blink is rolled. A chromium patch is reviewed and ready for dcommit.
>>>
https://chromiumcodereview.**appspot.com/15006004/<https://chromiumcodereview...
>>>
>>>  Unifies ScrollView and RenderLayer to use non-shifted [minPos, maxPos]
>>>> scroll
>>>>
>>> offset
>>>
>>>  For pages with negative overflow (due to RTL or writing mode), there are
>>>> two sets of scroll offset defined. One that ranges from [0, maxPos -
>>>> minPos]
>>>> and the other one ranges from [minPos, maxPos]. To reduce confusion,
>>>> this
>>>> patch unifies ScrollView and RenderLayer to use the second definition of
>>>> scroll offset.
>>>>
>>>
>>>  BUG=232063
>>>> TEST=manual
>>>> R=jamesr@chromium.org,jchaffra**ix@chromium.org<jchaffraix@chromium.org>
>>>>
>>>
>>>  Review URL:
https://chromiumcodereview.**appspot.com/14807003<https://chromiumcodereview....
>>>>
>>>
>>> TBR=jamesr@chromium.org,jchaff**raix@chromium.org<jchaffraix@chromium.org>
>>>
>>> Committed: https://src.chromium.org/**viewvc/blink?view=rev&**
>>>
revision=150264<https://src.chromium.org/viewvc/blink?view=rev&revision=150264>
>>>
>>> Please review this at
https://codereview.chromium.**org/15093011/<https://codereview.chromium.org/1...
>>>
>>> SVN Base:
svn://svn.chromium.org/blink/**trunk<http://svn.chromium.org/blink/trunk>
>>>
>>> Affected files:
>>>   M LayoutTests/TestExpectations
>>>   M LayoutTests/compositing/**overflow/composited-scrolling-**
>>> creates-a-stacking-container-**expected.txt
>>>   M LayoutTests/compositing/**overflow/composited-scrolling-**
>>> paint-phases-expected.txt
>>>   M LayoutTests/compositing/**overflow/scrolling-content-**
>>> clip-to-viewport-expected.txt
>>>   M LayoutTests/compositing/**overflow/scrolling-without-**
>>> painting-expected.txt
>>>   M LayoutTests/compositing/**overflow/textarea-scroll-**
>>> touch-expected.txt
>>>   M LayoutTests/compositing/**overflow/updating-scrolling-**
>>> content-expected.txt
>>>   M LayoutTests/fast/multicol/**shrink-to-column-height-for-**
>>> pagination.html
>>>   M LayoutTests/platform/chromium-**linux/compositing/overflow/**
>>> scrolling-without-painting-**expected.txt
>>>   M LayoutTests/platform/chromium-**linux/compositing/overflow/**
>>> updating-scrolling-content-**expected.txt
>>>   M LayoutTests/platform/chromium-**linux/virtual/gpu/**
>>> compositedscrolling/overflow/**scrolling-content-clip-to-**
>>> viewport-expected.txt
>>>   M LayoutTests/platform/chromium-**linux/virtual/gpu/**
>>> compositedscrolling/overflow/**scrolling-without-painting-**expected.txt
>>>   M LayoutTests/platform/chromium-**linux/virtual/gpu/**
>>> compositedscrolling/overflow/**updating-scrolling-content-**expected.txt
>>>   M LayoutTests/platform/chromium-**linux/virtual/**
>>> softwarecompositing/overflow/**scrolling-content-clip-to-**
>>> viewport-expected.txt
>>>   M LayoutTests/platform/chromium-**linux/virtual/**
>>> softwarecompositing/overflow/**scrolling-without-painting-**expected.txt
>>>   M LayoutTests/platform/chromium-**linux/virtual/**
>>> softwarecompositing/overflow/**updating-scrolling-content-**expected.txt
>>>   M LayoutTests/platform/chromium-**mac/compositing/overflow/**
>>> textarea-scroll-touch-**expected.txt
>>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>>> composited-scrolling-creates-**a-stacking-container-expected.**txt
>>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>>> composited-scrolling-paint-**phases-expected.txt
>>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>>> overflow-auto-with-touch-**expected.txt
>>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>>> overflow-auto-with-touch-**toggle-expected.txt
>>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>>> scrolling-without-painting-**expected.txt
>>>   M LayoutTests/virtual/gpu/**compositedscrolling/overflow/**
>>> updating-scrolling-content-**expected.txt
>>>   M LayoutTests/virtual/**softwarecompositing/overflow/**
>>> composited-scrolling-creates-**a-stacking-container-expected.**txt
>>>   M LayoutTests/virtual/**softwarecompositing/overflow/**
>>> composited-scrolling-paint-**phases-expected.txt
>>>   M LayoutTests/virtual/**softwarecompositing/overflow/**
>>> scrolling-without-painting-**expected.txt
>>>   M LayoutTests/virtual/**softwarecompositing/overflow/**
>>> updating-scrolling-content-**expected.txt
>>>   M Source/WebKit/chromium/tests/**ScrollAnimatorNoneTest.cpp
>>>   M Source/core/platform/**ScrollAnimator.cpp
>>>   M Source/core/platform/**ScrollView.cpp
>>>   M Source/core/platform/**ScrollableArea.h
>>>   M Source/core/platform/**Scrollbar.cpp
>>>   M Source/core/platform/graphics/**chromium/**GraphicsLayerChromium.cpp
>>>   M Source/core/platform/mac/**ScrollAnimatorMac.mm
>>>   M Source/core/rendering/**RenderLayer.h
>>>   M Source/core/rendering/**RenderLayer.cpp
>>>   M Source/core/rendering/**RenderLayerBacking.cpp
>>>
>>>
>>>
>

[eseidel, 2013-05-16 23:08:40]

virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style.html
looks to be failing after this.  The clip region looks wrong.  The text looks
clipped for a non-existant scroll bar?

[trchen, 2013-05-16 23:20:23]

On 2013/05/16 23:08:40, eseidel wrote:
>
virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style.html
> looks to be failing after this.  The clip region looks wrong.  The text looks
> clipped for a non-existant scroll bar?

The new clip region is correct, as mentioned by the text in the test.
Basically the test creates a custom scrollbar that only has a width but without
other properties. The client area should still be clipped by the (blank) custom
scrollbar.

Is the bot failing after I landed the other patch that rebaseline the PNGs? If
that's the case I probably missed some of the platforms then.