Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/perf/perf_tools/memory_measurement.py

Issue 15093008: Telemetry: integrates memory_measurement with TCMalloc dumps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/perf_tools/memory_measurement.py
diff --git a/tools/perf/perf_tools/memory_measurement.py b/tools/perf/perf_tools/memory_measurement.py
index 8d1724d146681d588c7afa23d47ff1dd287cef09..1ac7d1c03d6d73deafed40375720824f91a54395 100644
--- a/tools/perf/perf_tools/memory_measurement.py
+++ b/tools/perf/perf_tools/memory_measurement.py
@@ -46,3 +46,16 @@ class MemoryMeasurement(page_measurement.PageMeasurement):
def MeasurePage(self, page, tab, results):
Dai Mikurube (NOT FULLTIME) 2013/05/14 15:07:07 Just a question. When is is called?
bulach 2013/05/14 15:34:17 afaict, this is called after all actions for a giv
Dai Mikurube (NOT FULLTIME) 2013/05/14 17:02:10 Got it. Thanks!
for h in self.histograms:
h.GetValue(page, tab, results)
+ dumps = eval(tab.EvaluateJavaScript("""
+ if (chrome && chrome.memoryBenchmarking &&
+ chrome.memoryBenchmarking.isHeapProfilerRunning()) {
Dai Mikurube (NOT FULLTIME) 2013/05/14 15:07:07 I'm not confident whether we should always dump wh
bulach 2013/05/14 15:34:17 good idea! done.
+ JSON.stringify([
+ chrome.memoryBenchmarking.heapProfilerDump('renderer'),
+ chrome.memoryBenchmarking.heapProfilerDump('browser'),
+ ]);
+ } else {
+ JSON.stringify([]);
+ }
+ """))
+ if dumps:
+ print 'Memory dumps available at ', dumps

Powered by Google App Engine
This is Rietveld 408576698