Telemetry: integrates memory_measurement with TCMalloc dumps

tools/perf/perf_tools/memory_measurement.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 from perf_tools import histogram_metric
 from telemetry.page import page_measurement
 
 MEMORY_HISTOGRAMS = [
     {'name': 'V8.MemoryExternalFragmentationTotal', 'units': 'percent'},
     {'name': 'V8.MemoryHeapSampleTotalCommitted', 'units': 'kb'},
     {'name': 'V8.MemoryHeapSampleTotalUsed', 'units': 'kb'},
     {'name': 'Memory.RendererUsed', 'units': 'kb'}]
 
 BROWSER_MEMORY_HISTOGRAMS =  [
     {'name': 'Memory.BrowserUsed', 'units': 'kb'}]
 
 class MemoryMeasurement(page_measurement.PageMeasurement):
   def __init__(self):
     super(MemoryMeasurement, self).__init__('stress_memory')
     self.histograms = (
         [histogram_metric.HistogramMetric(
             h, histogram_metric.RENDERER_HISTOGRAM)
          for h in MEMORY_HISTOGRAMS] +
         [histogram_metric.HistogramMetric(
             h, histogram_metric.BROWSER_HISTOGRAM)
          for h in BROWSER_MEMORY_HISTOGRAMS])
+    self._is_running_tcmalloc_heap_profiler = False
 
   def DidNavigateToPage(self, page, tab):
     for h in self.histograms:
       h.Start(page, tab)
 
   def CustomizeBrowserOptions(self, options):
     options.AppendExtraBrowserArg('--dom-automation')
     # For a hard-coded set of Google pages (such as GMail), we produce custom
     # memory histograms (V8.Something_gmail) instead of the generic histograms
     # (V8.Something), if we detect that a renderer is only rendering this page
     # and no other pages. For this test, we need to disable histogram
     # customizing, so that we get the same generic histograms produced for all
     # pages.
     options.AppendExtraBrowserArg('--disable-histogram-customizer')
     options.AppendExtraBrowserArg('--memory-metrics')
     options.AppendExtraBrowserArg('--reduce-security-for-dom-automation-tests')
+    self._is_running_tcmalloc_heap_profiler = (options.profiler_tool ==
+        'tcmalloc-heap')
 
   def CanRunForPage(self, page):
     return hasattr(page, 'stress_memory')
 
   def MeasurePage(self, page, tab, results):
     for h in self.histograms:
       h.GetValue(page, tab, results)
+    if self._is_running_tcmalloc_heap_profiler:

[tonyg, 2013/05/15 15:46:17]

I think you could remove the member variable and check
tab.browser.options.profiler_tool inline here.

[bulach, 2013/05/16 09:01:30]

that's actually a good point.
browser doesn't expose options though, so rather than doing that, I created a
"browser.is_profiler_active(self, name)" , which seems a nicer API to have...

+      # The tcmalloc_heap_profiler dumps files at regular
+      # intervals (~20 secs).
+      # This is a minor optimization to ensure it'll dump the last file when
+      # the test completes.
+      tab.ExecuteJavaScript("""
+        if (chrome && chrome.memoryBenchmarking) {
+          chrome.memoryBenchmarking.heapProfilerDump('final', 'renderer');
+          chrome.memoryBenchmarking.heapProfilerDump('final', 'browser');
+        }
+      """)