src/js/i18n.js - Issue 1509273007: Allow ICU to normalize time zones

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/i18n.js

Issue 1509273007: Allow ICU to normalize time zones (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Misspell shorter Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/js/i18n.js

diff --git a/src/js/i18n.js b/src/js/i18n.js

index b2eef6f18dd126e82fa2df91ffecad55cafacb42..a859a9fbeb9f1028e0c6245364a800651d8e7f29 100644

--- a/src/js/i18n.js

+++ b/src/js/i18n.js

@@ -1574,7 +1574,7 @@ function initializeDateTimeFormat(dateFormat, locales, options) {

var formatter = %CreateDateTimeFormat(

requestedLocale, {skeleton: ldmlString, timeZone: tz}, resolved);

- if (!IS_UNDEFINED(tz) && tz !== resolved.timeZone) {

+ if (resolved.timeZone === "Etc/Unknown") {

throw MakeRangeError(kUnsupportedTimeZone, tz);

}

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-487322.js » ('j') | no next file with comments »