Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: src/DartARM32/assembler_arm.cc

Issue 1509243002: Add ASR instruction to the ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/DartARM32/assembler_arm.h ('k') | src/IceAssemblerARM32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/DartARM32/assembler_arm.cc
diff --git a/src/DartARM32/assembler_arm.cc b/src/DartARM32/assembler_arm.cc
index 37291e2fb62e05eb145c559e7f2372a51dcbb3d8..a5fe0ccaa3dd0e8e42b92f3452bd63c46a2545b3 100644
--- a/src/DartARM32/assembler_arm.cc
+++ b/src/DartARM32/assembler_arm.cc
@@ -2620,9 +2620,8 @@ void Assembler::Lsr(Register rd, Register rm, const Operand& shift_imm,
void Assembler::Lsr(Register rd, Register rm, Register rs, Condition cond) {
mov(rd, Operand(rm, LSR, rs), cond);
}
-#endif
-
+// Moved to ARM32::AssemblerARM32::asr()
void Assembler::Asr(Register rd, Register rm, const Operand& shift_imm,
Condition cond) {
ASSERT(shift_imm.type() == 1);
@@ -2633,7 +2632,7 @@ void Assembler::Asr(Register rd, Register rm, const Operand& shift_imm,
}
mov(rd, Operand(rm, ASR, shift), cond);
}
-
+#endif
void Assembler::Asrs(Register rd, Register rm, const Operand& shift_imm,
Condition cond) {
@@ -2646,11 +2645,12 @@ void Assembler::Asrs(Register rd, Register rm, const Operand& shift_imm,
movs(rd, Operand(rm, ASR, shift), cond);
}
-
+#if 0
+// Moved to ARM32::AssemblerARM32::asr()
void Assembler::Asr(Register rd, Register rm, Register rs, Condition cond) {
mov(rd, Operand(rm, ASR, rs), cond);
}
-
+#endif
void Assembler::Ror(Register rd, Register rm, const Operand& shift_imm,
Condition cond) {
« no previous file with comments | « src/DartARM32/assembler_arm.h ('k') | src/IceAssemblerARM32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698