xfa/src/fxfa/src/app/xfa_fffield.cpp - Issue 1509203002: FWL refcounts never incremented (part 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxfa/src/app/xfa_fffield.cpp

Issue 1509203002: FWL refcounts never incremented (part 1) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: protected Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxfa/src/app/xfa_fffield.cpp

diff --git a/xfa/src/fxfa/src/app/xfa_fffield.cpp b/xfa/src/fxfa/src/app/xfa_fffield.cpp

index 9b70f65eae76aed388c5b2e318da52de156643c8..22d1bf1791ca7d066ff1e1e8b06ff5ca24b6478c 100644

--- a/xfa/src/fxfa/src/app/xfa_fffield.cpp

+++ b/xfa/src/fxfa/src/app/xfa_fffield.cpp

@@ -127,10 +127,8 @@ FX_BOOL CXFA_FFField::LoadWidget() {

return TRUE;

}

void CXFA_FFField::UnloadWidget() {

- if (m_pNormalWidget) {

- m_pNormalWidget->Release();

- m_pNormalWidget = NULL;

- }

+ delete m_pNormalWidget;

+ m_pNormalWidget = nullptr;

}

void CXFA_FFField::SetEditScrollOffset() {

XFA_ELEMENT eType = m_pDataAcc->GetUIType();

« no previous file with comments | « xfa/src/fwl/src/lightwidget/widget.cpp ('k') | no next file » | no next file with comments »