Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: xfa/include/fwl/core/fwl_target.h

Issue 1509203002: FWL refcounts never incremented (part 1) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: protected Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/include/fwl/core/fwl_note.h ('k') | xfa/include/fwl/lightwidget/widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/include/fwl/core/fwl_target.h
diff --git a/xfa/include/fwl/core/fwl_target.h b/xfa/include/fwl/core/fwl_target.h
index bf5cf83f3aef394bb899964de97773f252c92660..dc10ca5399b69116462f66107ae2b65b7a86e005 100644
--- a/xfa/include/fwl/core/fwl_target.h
+++ b/xfa/include/fwl/core/fwl_target.h
@@ -16,7 +16,7 @@
// (nonesuch) IFWL_Target ----------> CFWL_TargetImp
// | |
// A A
-// m_pIface | |
+// m_pIface | |
// CFWL_Widget ----------> IFWL_Widget CFWL_WidgetImp
// | | |
// A A A
@@ -29,10 +29,8 @@ class CFWL_TargetImp;
class IFWL_Target {
public:
IFWL_Target() : m_pImpl(nullptr) {}
+ virtual ~IFWL_Target();
- FX_DWORD Release();
- IFWL_Target* Retain();
- FX_DWORD GetRefCount() const;
FWL_ERR GetClassName(CFX_WideString& wsClass) const;
FX_DWORD GetClassID() const;
FX_BOOL IsInstance(const CFX_WideStringC& wsClass) const;
@@ -42,9 +40,6 @@ class IFWL_Target {
CFWL_TargetImp* GetImpl() const { return m_pImpl; }
void SetImpl(CFWL_TargetImp* pImpl) { m_pImpl = pImpl; }
- protected:
- virtual ~IFWL_Target();
-
private:
CFWL_TargetImp* m_pImpl;
};
« no previous file with comments | « xfa/include/fwl/core/fwl_note.h ('k') | xfa/include/fwl/lightwidget/widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698