Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1509193003: suggest async* and sync* - fixes 24554 (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -17 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 7 chunks +33 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 5 chunks +42 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-08 18:41:51 UTC) #2
scheglov
LGTM
5 years ago (2015-12-08 18:43:03 UTC) #3
danrubel
5 years ago (2015-12-08 20:07:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c66a5d3fb534b1688a159f3b3fc467c5fb45c371 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698