Chromium Code Reviews

Issue 1509123002: C++11 style guide: Ban alignas/alignof for now. (Closed)

Created:
5 years ago by Yuta Kitamura
Modified:
5 years ago
Reviewers:
Nico
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

C++11 style guide: Ban alignas/alignof for now. This patch moves C++11 alignment features (alignas/alignof) to the banned language features section, since MSVS 2013 does not support them. MSVS 2015 seems to support them, so we can revisit once MSVS 2015 is rolled out. Discussion thread: https://groups.google.com/a/chromium.org/forum/#!msg/cxx/rwXN02jzzq0/CpUc1ZzMBQAJ BUG=none Committed: https://crrev.com/175dd5beb2d5ec621488ed1ce82916fa18dce5c0 Cr-Commit-Position: refs/heads/master@{#363798}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+19 lines, -10 lines)
M styleguide/c++/c++11.html View 2 chunks +19 lines, -10 lines 0 comments

Messages

Total messages: 10 (5 generated)
Yuta Kitamura
See discussion thread for context. I will land once the discussion is settled (after a ...
5 years ago (2015-12-08 08:33:56 UTC) #3
Nico
lgtm, thanks!
5 years ago (2015-12-08 15:28:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509123002/1
5 years ago (2015-12-08 15:28:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 21:51:32 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-08 21:52:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/175dd5beb2d5ec621488ed1ce82916fa18dce5c0
Cr-Commit-Position: refs/heads/master@{#363798}

Powered by Google App Engine