Remove support for Mac OS X Leopard (10.5)

Remove support for Mac OS X Leopard (10.5)

No need to support it in trunk. WebKit already dropped it in r149922.
Adjust usage of __MAC_OS_X_VERSION_MIN_REQUESTED and __MAC_OS_X_VERSION_MAX_ALLOWED
macros and remove dead code.

R=abarth@chromium.org, thakis@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151264

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152825

[kbalazs_, 2013-05-20 14:02:26]

This merges the relevant part of http://trac.webkit.org/changeset/149922

[abarth-chromium, 2013-05-20 17:22:46]

lgtm

[commit-bot: I haz the power, 2013-05-20 17:22:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/15091005/2001

[commit-bot: I haz the power, 2013-05-20 17:33:17]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[Nico, 2013-05-20 18:15:55]

lgtm

Thanks for the patch! The presubmit is wrong. I'll land this manually for you.

[Nico, 2013-05-20 18:21:01]

Actually, not lgtm. I don't see you on the list of CLA signers.

You need to sign either https://developers.google.com/open-source/cla/corporate
or https://developers.google.com/open-source/cla/individual . Samsung has signed
this, but only for a limited list of people, but not for you as far as I can
tell.

[Nico, 2013-05-20 18:21:33]

(Ping this review once you've done this, then I'll land the patch.)


On Mon, May 20, 2013 at 11:21 AM, <thakis@chromium.org> wrote:

> Actually, not lgtm. I don't see you on the list of CLA signers.
>
> You need to sign either https://developers.google.com/**
>
open-source/cla/corporate<https://developers.google.com/open-source/cla/corporate>
> or
https://developers.google.com/**open-source/cla/individual<https://developers....
Samsung has signed
> this, but only for a limited list of people, but not for you as far as I
> can
> tell.
>
>
https://chromiumcodereview.**appspot.com/15091005/<https://chromiumcodereview...
>

[lgombos, 2013-05-20 19:58:46]

On 2013/05/20 18:21:01, Nico wrote:
> Actually, not lgtm. I don't see you on the list of CLA signers.
> 
> You need to sign either
https://developers.google.com/open-source/cla/corporate
> or https://developers.google.com/open-source/cla/individual . Samsung has
signed
> this, but only for a limited list of people, but not for you as far as I can
> tell.

Nico, thanks good point. I sent in the corporate CLA for Samsung, I will add
Balazs to it. Laszlo

[Peter Kasting, 2013-05-20 20:28:52]

Also, FYI, in the future please always say what you want each reviewer to look
at when you specify multiple reviewers.

In this case, I'm not an appropriate reviewer for any of the files here.

[kbalazs_, 2013-05-22 15:44:36]

> > Actually, not lgtm. I don't see you on the list of CLA signers.
> >
> > You need to sign either https://developers.google.com/**
> >
>
open-source/cla/corporate<https://developers.google.com/open-source/cla/corporate>
> > or
>
https://developers.google.com/**open-source/cla/individual%3Chttps://develope...>.
> Samsung has signed
> > this, but only for a limited list of people, but not for you as far as I
> > can
> > tell.
> >
> >
>
https://chromiumcodereview.**appspot.com/15091005/%3Chttps://chromiumcoderevi...>
> >

That's right, I was missing from that. We have requested to extend the list in
the CLA with myself (among some other folks). We did not get a replay yet, so
I'm not sure whether I am already on the list . Could you be so kind and take
another look? Otherwise I will ping if I will get notified about it.

[Nico, 2013-05-22 16:13:10]

On Wed, May 22, 2013 at 8:44 AM, <b.kelemen@sisa.samsung.com> wrote:

> > Actually, not lgtm. I don't see you on the list of CLA signers.
>> >
>> > You need to sign either
https://developers.google.com/****<https://developers.google.com/**>
>> >
>>
>
> open-source/cla/corporate<http**s://developers.google.com/**
>
open-source/cla/corporate<https://developers.google.com/open-source/cla/corporate>
> >
>
>> > or
>>
>
> https://developers.google.com/****open-source/cla/individual%**
>
3Chttps://developers.google.**com/open-source/cla/individual<https://developers.google.com/**open-source/cla/individual%3Chttps://developers.google.com/open-source/cla/individual>
> **>.
>
>  Samsung has signed
>> > this, but only for a limited list of people, but not for you as far as I
>> > can
>> > tell.
>> >
>> >
>>
>
> https://chromiumcodereview.**a**ppspot.com/15091005/%3Chttps:/**
>
/chromiumcodereview.appspot.**com/15091005/<http://appspot.com/15091005/%3Chttps://chromiumcodereview.appspot.com/15091005/>
> >
>
>> >
>>
>
> That's right, I was missing from that. We have requested to extend the
> list in
> the CLA with myself (among some other folks). We did not get a replay yet,
> so
> I'm not sure whether I am already on the list . Could you be so kind and
> take
> another look? Otherwise I will ping if I will get notified about it.
>

I couldn't find you on the list yet. Sorry about the delay :-/


>
>
https://codereview.chromium.**org/15091005/<https://codereview.chromium.org/1...
>

[lgombos, 2013-05-28 15:10:10]

On 2013/05/22 16:13:10, Nico wrote:
> On Wed, May 22, 2013 at 8:44 AM, <mailto:b.kelemen@sisa.samsung.com> wrote:
> 
> > > Actually, not lgtm. I don't see you on the list of CLA signers.

I was informed that Balazs has been added to the list of CLA signers.

[kbalazs_, 2013-05-28 15:16:33]

We have informed that the CLA has been updated with myself. It still applies
finely so I'm going to check the commit box again.

[commit-bot: I haz the power, 2013-05-28 15:17:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/15091005/2001

[commit-bot: I haz the power, 2013-05-28 15:24:07]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[Nico, 2013-05-28 15:46:56]

lgtm, confirmed

[Nico, 2013-05-28 15:56:20]

Committed patchset #2 manually as r151264 (presubmit successful).

[Nico, 2013-05-28 15:56:38]

landed in r151264

[Nico, 2013-05-28 16:49:26]

Reverted (in r151266), apparently broke mac compile: FAILED: clang++ -MMD -MF
obj/third_party/webkit/source/core/platform/graphics/cocoa/webcore_platform.fontplatformdatacocoa.o.d
-DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN
-DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS
-DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS
-DENABLE_HIDPI=1 -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1
-DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1
-DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_LANGUAGE_DETECTION=1
-DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
-DENABLE_MANAGED_USERS=1 '-DWEBCORE_NAVIGATOR_VENDOR="Google Inc."'
-DWEBKIT_IMPLEMENTATION=1 '-DWEBCORE_NAVIGATOR_PLATFORM="MacIntel"'
-DWebCascadeList=ChromiumWebCoreObjCWebCascadeList
-DWebCoreFlippedView=ChromiumWebCoreObjCWebCoreFlippedView
-DWebCoreTextFieldCell=ChromiumWebCoreObjCWebCoreTextFieldCell
-DWebScrollbarPrefsObserver=ChromiumWebCoreObjCWebScrollbarPrefsObserver
-DWebCoreRenderThemeNotificationObserver=ChromiumWebCoreObjCWebCoreRenderThemeNotificationObserver
-DWebFontCache=ChromiumWebCoreObjCWebFontCache
-DWebScrollAnimationHelperDelegate=ChromiumWebCoreObjCWebScrollAnimationHelperDelegate
-DWebScrollbarPainterControllerDelegate=ChromiumWebCoreObjCWebScrollbarPainterControllerDelegate
-DWebScrollbarPainterDelegate=ChromiumWebCoreObjCWebScrollbarPainterDelegate
-DWebScrollbarPartAnimation=ChromiumWebCoreObjCWebScrollbarPartAnimation
-DENABLE_3D_PLUGIN=1 -DENABLE_BATTERY_STATUS=0 -DENABLE_CANVAS_USES_MAILBOX=0
-DENABLE_CSS3_TEXT=0 -DENABLE_CSS_DEVICE_ADAPTATION=0 -DENABLE_CSS_EXCLUSIONS=1
-DENABLE_CSS_REGIONS=1 -DENABLE_CUSTOM_SCHEME_HANDLER=0
-DENABLE_ENCRYPTED_MEDIA_V2=1 -DENABLE_SVG=1 -DENABLE_SVG_FONTS=1
-DENABLE_TOUCH_ICON_LOADING=0 -DENABLE_WEBGL=1 -DENABLE_XHR_TIMEOUT=0
-DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_CALENDAR_PICKER=1
-DENABLE_INPUT_SPEECH=1 -DENABLE_INPUT_TYPE_COLOR=1
-DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DENABLE_LEGACY_NOTIFICATIONS=1
-DENABLE_MEDIA_CAPTURE=0 -DENABLE_NAVIGATOR_CONTENT_UTILS=1
-DENABLE_NOTIFICATIONS=1 -DENABLE_ORIENTATION_EVENTS=0 -DENABLE_WEB_AUDIO=1
-DENABLE_8BIT_TEXTRUN=1 -DENABLE_RUBBER_BANDING=1 -DWTF_USE_NEW_THEME=1
-DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION -DSK_BUILD_NO_IMAGE_ENCODE
-DSK_DEFERRED_CANVAS_USES_GPIPE=1
'-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
-DGR_AGGRESSIVE_SHADER_OPTS=1 -DSK_ENABLE_INST_COUNT=0 -DSK_USE_POSIX_THREADS
-DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DLIBXML_STATIC -DLIBXSLT_STATIC
-DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0
-I../../third_party/icu/public/common -I../../third_party/icu/public/i18n
-I../../third_party/khronos -I../../gpu -I../..
-I../../third_party/WebKit/Source -Igen/webkit -Igen/webkit/bindings
-I../../third_party/angle/include/GLSLANG
-I../../third_party/WebKit/Source/Platform/chromium -I../../skia/config
-I../../third_party/skia/src/core -I../../third_party/skia/include/config
-I../../third_party/skia/include/core -I../../third_party/skia/include/effects
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
-I../../third_party/skia/include/gpu/gl -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils -I../../skia/ext
-I../../third_party/skia/include/utils/mac -I../../third_party/iccjpeg
-I../../third_party/leveldatabase/src/include
-I../../third_party/leveldatabase/src -I../../third_party/leveldatabase
-I../../third_party/libwebp -I../../third_party/libpng
-I../../third_party/libxml/mac/include -I../../third_party/libxml/src/include
-I../../third_party/libxslt -I../../third_party/npapi
-I../../third_party/npapi/bindings -I../../third_party/ots/include
-I../../third_party/qcms/src -I../../third_party/sqlite -I../../third_party/zlib
-I../../v8/include -I../../third_party/libjpeg_turbo
-I../../third_party/harfbuzz-ng/src -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk
-O3 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch
i386 -Wendif-labels -Wno-unused-parameter -Wno-missing-field-initializers
-Wheader-hygiene -Wno-c++11-narrowing -Wno-reserved-user-defined-literal
-Wno-char-subscripts -Wno-unused-function -Wno-covered-switch-default
-Wstring-conversion -Wglobal-constructors -Wexit-time-destructors -fno-rtti
-fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang
-load -Xclang
/Volumes/data/b/build/slave/Mac10_8_Tests/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics
-fno-strict-aliasing -std=gnu++11 -fobjc-call-cxx-cdtors -include
../../third_party/WebKit/Source/core/WebCorePrefixMac.h -c
../../third_party/WebKit/Source/core/platform/graphics/cocoa/FontPlatformDataCocoa.mm
-o
obj/third_party/webkit/source/core/platform/graphics/cocoa/webcore_platform.fontplatformdatacocoa.o
../../third_party/WebKit/Source/core/platform/graphics/cocoa/FontPlatformDataCocoa.mm:242:128:
error: expected ')'
        m_CTFont.adoptCF(CTFontCreateWithGraphicsFont(m_inMemoryFont->cgFont(),
m_size, 0, cascadeToLastResortFontDescriptor());
                                                                                
                                              ^

Did you try building this locally at all?

[kbalazs_, 2013-05-28 17:03:46]

> Did you try building this locally at all?

Sorry, actually I did not.
As it happened that way, I'm going to fix the style issue. Laszlo told me you
proposed an Obj-C style retain to silence the presubmit. Than we can go through
the bots landing it (actually I don't have access to a Mac now so it's better).

[Nico, 2013-05-28 17:05:28]

On Tue, May 28, 2013 at 10:03 AM, <b.kelemen@sisa.samsung.com> wrote:

> Did you try building this locally at all?
>>
>
> Sorry, actually I did not.
>
As it happened that way, I'm going to fix the style issue. Laszlo told me
> you
> proposed an Obj-C style retain to silence the presubmit. Than we can go
> through
> the bots landing it (actually I don't have access to a Mac now so it's
> better


Probably best to not write patches for platforms that you can't build on
locally.


> ).
>
>
https://codereview.chromium.**org/15091005/<https://codereview.chromium.org/1...
>

[kbalazs_, 2013-06-18 19:42:59]

Oops, I forgot about that. It still applies so I am going to land it via the
bots if there is no opposition.

[Nico, 2013-06-18 19:43:48]

On 2013/06/18 19:42:59, kbalazs wrote:
> Oops, I forgot about that. It still applies so I am going to land it via the
> bots if there is no opposition.

If you can build with this.

[commit-bot: I haz the power, 2013-06-20 19:57:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/15091005/28001

[commit-bot: I haz the power, 2013-06-20 21:19:18]

Change committed as 152825