Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: chrome/test/data/extensions/api_test/permissions/optional_deny/background.js

Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more comments and fixed tests Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/permissions/optional_deny/background.js
diff --git a/chrome/test/data/extensions/api_test/permissions/optional_deny/background.js b/chrome/test/data/extensions/api_test/permissions/optional_deny/background.js
index 0c6d0e1685c6b790db5bef48e7a2ef66ed5bdb59..f6b2abe8a1bd25f3d1469a9bf952688c75b0d772 100644
--- a/chrome/test/data/extensions/api_test/permissions/optional_deny/background.js
+++ b/chrome/test/data/extensions/api_test/permissions/optional_deny/background.js
@@ -6,9 +6,6 @@ var assertFalse = chrome.test.assertFalse;
var assertTrue = chrome.test.assertTrue;
var pass = chrome.test.callbackPass;
-var NO_BOOKMARKS_PERMISSION =
- "You do not have permission to use 'bookmarks.getTree'.";
-
chrome.test.getConfig(function(config) {
function doReq(domain, callback) {
@@ -48,13 +45,9 @@ chrome.test.getConfig(function(config) {
{permissions: ['bookmarks'], origins:['http://*.c.com/*']},
pass(function(result) { assertFalse(result); }));
- try {
- chrome.bookmarks.getTree(function() {
- chrome.test.fail("Should not have bookmarks API permission.");
- });
- } catch (e) {
- assertTrue(e.message.indexOf(NO_BOOKMARKS_PERMISSION) == 0);
- }
+ chrome.bookmarks.getTree(function(result) {
+ assertFalse(chrome.runtime.lastError === undefined);
not at google - send to devlin 2013/05/30 16:38:52 same
+ });
doReq('http://b.c.com/', pass(function(result) {
assertFalse(result);

Powered by Google App Engine
This is Rietveld 408576698