chrome/renderer/extensions/v8_schema_registry.h - Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/v8_schema_registry.h

Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more comments and fixed tests Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/dispatcher.cc ('K') | « chrome/renderer/extensions/dispatcher.cc ('k') | chrome/renderer/extensions/v8_schema_registry.cc » ('j') | chrome/test/data/extensions/api_test/events/background.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/v8_schema_registry.h

diff --git a/chrome/renderer/extensions/v8_schema_registry.h b/chrome/renderer/extensions/v8_schema_registry.h

index 9a7a6957cdee1aad454ce13f7d189ebb5c93c3ca..1cf81fb37c3de3528c114eb0be26a5cbaced5969 100644

--- a/chrome/renderer/extensions/v8_schema_registry.h

+++ b/chrome/renderer/extensions/v8_schema_registry.h

@@ -6,8 +6,8 @@

#define CHROME_RENDERER_EXTENSIONS_V8_SCHEMA_REGISTRY_H_

#include <map>

-#include <set>

#include <string>

+#include <vector>

#include "base/basictypes.h"

#include "chrome/renderer/extensions/scoped_persistent.h"

@@ -23,7 +23,7 @@ class V8SchemaRegistry {

~V8SchemaRegistry();

// Returns a v8::Array with all the schemas for the APIs in |apis|.

- v8::Handle<v8::Array> GetSchemas(const std::set<std::string>& apis);

+ v8::Handle<v8::Array> GetSchemas(const std::vector<std::string>& apis);

// Returns a v8::Object for the schema for |api|, possibly from the cache.

v8::Handle<v8::Object> GetSchema(const std::string& api);