chrome/common/extensions/features/base_feature_provider.h - Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/base_feature_provider.h

Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more comments and fixed tests Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/extension_api.cc ('K') | « chrome/common/extensions/api/test.json ('k') | chrome/common/extensions/features/base_feature_provider.cc » ('j') | chrome/common/extensions/features/base_feature_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/base_feature_provider.h

diff --git a/chrome/common/extensions/features/base_feature_provider.h b/chrome/common/extensions/features/base_feature_provider.h

index 0d467c03169d7cd2ecebccd7e75d7a1b7b1f5d82..31200ff94004a40859943d313231445cef5119a3 100644

--- a/chrome/common/extensions/features/base_feature_provider.h

+++ b/chrome/common/extensions/features/base_feature_provider.h

@@ -6,8 +6,8 @@

#define CHROME_COMMON_EXTENSIONS_FEATURES_BASE_FEATURE_PROVIDER_H_

#include <map>

-#include <set>

#include <string>

+#include <vector>

#include "base/memory/linked_ptr.h"

#include "base/values.h"

@@ -36,12 +36,14 @@ class BaseFeatureProvider : public FeatureProvider {

// Gets the feature |feature_name|, if it exists.

virtual Feature* GetFeature(const std::string& feature_name) OVERRIDE;

- virtual std::set<std::string> GetAllFeatureNames() OVERRIDE;

+ virtual const std::vector<std::string>& GetAllFeatureNames() OVERRIDE;

private:

typedef std::map<std::string, linked_ptr<Feature> > FeatureMap;

FeatureMap features_;

+ std::vector<std::string> feature_names_;

FeatureFactory factory_;

};