chrome/common/extensions/manifest.cc - Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest.cc

Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix chromeos tests Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/features/simple_feature_unittest.cc ('k') | chrome/renderer/extensions/api_definitions_natives.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest.cc

diff --git a/chrome/common/extensions/manifest.cc b/chrome/common/extensions/manifest.cc

index 52ce77bbc6e8428c09a033abd539f560a62369f4..c8cedf19e6c19a8ebe78137d05317a12e6194e81 100644

--- a/chrome/common/extensions/manifest.cc

+++ b/chrome/common/extensions/manifest.cc

@@ -142,8 +142,10 @@ bool Manifest::ValidateManifest(

// checking to let developers know when they screw up.

FeatureProvider* provider = BaseFeatureProvider::GetByName("manifest");

- std::set<std::string> feature_names = provider->GetAllFeatureNames();

- for (std::set<std::string>::iterator feature_name = feature_names.begin();

+ const std::vector<std::string>& feature_names =

+ provider->GetAllFeatureNames();

+ for (std::vector<std::string>::const_iterator feature_name =

+ feature_names.begin();

feature_name != feature_names.end(); ++feature_name) {

// Use Get instead of HasKey because the former uses path expansion.

if (!value_->Get(*feature_name, NULL))