Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1558)

Unified Diff: chrome/common/extensions/features/base_feature_provider.h

Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix chromeos tests Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/test.json ('k') | chrome/common/extensions/features/base_feature_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/features/base_feature_provider.h
diff --git a/chrome/common/extensions/features/base_feature_provider.h b/chrome/common/extensions/features/base_feature_provider.h
index 0d467c03169d7cd2ecebccd7e75d7a1b7b1f5d82..6a80e10e202249f9d9e650dec403d8ae9e78aed4 100644
--- a/chrome/common/extensions/features/base_feature_provider.h
+++ b/chrome/common/extensions/features/base_feature_provider.h
@@ -6,8 +6,8 @@
#define CHROME_COMMON_EXTENSIONS_FEATURES_BASE_FEATURE_PROVIDER_H_
#include <map>
-#include <set>
#include <string>
+#include <vector>
#include "base/memory/linked_ptr.h"
#include "base/values.h"
@@ -35,13 +35,16 @@ class BaseFeatureProvider : public FeatureProvider {
// Gets the feature |feature_name|, if it exists.
virtual Feature* GetFeature(const std::string& feature_name) OVERRIDE;
+ virtual Feature* GetParent(Feature* feature) OVERRIDE;
- virtual std::set<std::string> GetAllFeatureNames() OVERRIDE;
+ virtual const std::vector<std::string>& GetAllFeatureNames() OVERRIDE;
private:
typedef std::map<std::string, linked_ptr<Feature> > FeatureMap;
FeatureMap features_;
+ std::vector<std::string> feature_names_;
+
FeatureFactory factory_;
};
« no previous file with comments | « chrome/common/extensions/api/test.json ('k') | chrome/common/extensions/features/base_feature_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698