chrome/test/data/extensions/api_test/events/manifest.json - Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/events/manifest.json

Issue 15091002: Lazily load API schemas from resource files and convert all APIs to features (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more comments and fixed tests Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/test/data/extensions/api_test/events/background.js ('K') | « chrome/test/data/extensions/api_test/events/background.js ('k') | chrome/test/data/extensions/api_test/permissions/optional/background.js » ('j') | chrome/test/data/extensions/api_test/permissions/optional/background.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "name": "permissions failure apitest",	2 "name": "permissions failure apitest",

3 "description": "permissions failure extension",	3 "description": "permissions failure extension",

4 "version": "0.1",	4 "version": "0.1",

5 "manifest_version": 2,	5 "manifest_version": 2,

	6 "browser_action": {},
	not at google - send to devlin 2013/05/30 16:38:52 there is a bug where if this is empty the extensio there is a bug where if this is empty the extension won't re-load. let's avoid surprised and add a default_title: 'apitest' or something in here. cduvall 2013/06/12 01:22:19 Done. Show quoted text On 2013/05/30 16:38:52, kalman wrote: > there is a bug where if this is empty the extension won't re-load. let's avoid > surprised and add a default_title: 'apitest' or something in here. Done.
6 "background": {	7 "background": {

7 "scripts": ["background.js"]	8 "scripts": ["background.js"]

8 },	9 },

9 "permissions": [ ]	10 "permissions": [ ]

10 }	11 }

OLD	NEW