Lazily load API schemas from resource files and convert all APIs to features

chrome/common/extensions/features/base_feature_provider_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/features/base_feature_provider.h"
 
 #include "chrome/common/extensions/features/permission_feature.h"
 #include "chrome/common/extensions/value_builder.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 86 matching lines @@
 }
 
 SimpleFeature* CreatePermissionFeature() {
   return new PermissionFeature();
 }
 
 TEST(BaseFeatureProviderTest, Validation) {
   scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue());
 
   base::DictionaryValue* feature1 = new base::DictionaryValue();
+  feature1->SetString("channel", "trunk");
   value->Set("feature1", feature1);
 
   base::DictionaryValue* feature2 = new base::DictionaryValue();
+  feature2->SetString("channel", "trunk");
   base::ListValue* extension_types = new base::ListValue();
   extension_types->Append(new base::StringValue("extension"));
   feature2->Set("extension_types", extension_types);
   base::ListValue* contexts = new base::ListValue();
   contexts->Append(new base::StringValue("blessed_extension"));
   feature2->Set("contexts", contexts);
   value->Set("feature2", feature2);
 
   scoped_ptr<BaseFeatureProvider> provider(
       new BaseFeatureProvider(*value, CreatePermissionFeature));
 
   // feature1 won't validate because it lacks an extension type.
   EXPECT_FALSE(provider->GetFeature("feature1"));
 
   // If we add one, it works.
   feature1->Set("extension_types", extension_types->DeepCopy());
   provider.reset(new BaseFeatureProvider(*value, CreatePermissionFeature));
   EXPECT_TRUE(provider->GetFeature("feature1"));
 
+  // Remove the channel, and feature1 won't validate.
+  feature1->Remove("channel", NULL);
+  provider.reset(new BaseFeatureProvider(*value, CreatePermissionFeature));
+  EXPECT_FALSE(provider->GetFeature("feature1"));
+
   // feature2 won't validate because of the presence of "contexts".
   EXPECT_FALSE(provider->GetFeature("feature2"));
 
   // If we remove it, it works.
   feature2->Remove("contexts", NULL);
   provider.reset(new BaseFeatureProvider(*value, CreatePermissionFeature));
   EXPECT_TRUE(provider->GetFeature("feature2"));
 }
 
 TEST(BaseFeatureProviderTest, ComplexFeatures) {
@@ skipping 39 matching lines @@
         Feature::UNSPECIFIED_PLATFORM).result());
     EXPECT_NE(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(
         "2",
         Manifest::TYPE_LEGACY_PACKAGED_APP,
         Feature::UNSPECIFIED_LOCATION,
         Feature::UNSPECIFIED_PLATFORM).result());
   }
 }
 
 }  // namespace extensions