Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1509033003: Promote `diagnostic.getDiagnostics()` (#25061). (Closed)

Created:
5 years ago by pquitslund
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, devoncarew
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Promote `diagnostic.getDiagnostics()` (#25061). * removes rolling average support * removes "experimental" tag * bumps API version Fixes #25061. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/2fdcb1bd74a55effbf32161fe2b50a8dce0053fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -170 lines) Patch
M pkg/analysis_server/doc/api.html View 4 chunks +54 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart View 8 chunks +2 lines, -30 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_diagnostic.dart View 5 chunks +1 line, -93 lines 0 comments Download
M pkg/analysis_server/test/domain_diagnostic_test.dart View 2 chunks +0 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/ContextData.java View 8 chunks +2 lines, -21 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 4 chunks +4 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
5 years ago (2015-12-08 22:48:49 UTC) #2
Brian Wilkerson
LGTM
5 years ago (2015-12-09 14:55:23 UTC) #3
pquitslund
5 years ago (2015-12-09 17:29:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2fdcb1bd74a55effbf32161fe2b50a8dce0053fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698