Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 150903005: Remove all_android.gyp. (Closed)

Created:
6 years, 10 months ago by Nico
Modified:
6 years, 10 months ago
Reviewers:
Torne
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Remove all_android.gyp. It's been unused for two weeks, and should be a noop for everyone who sourced envsetup since. If you see an error message like gyp: buid/all_android.gyp not found (cwd: /path/to/chrome/src) after this change, open a fresh shell (and source envsetup), or run `unset CHROMIUM_GYP_FILE`. Also remove the code for unsetting CHROMIUM_GYP_FIE from envsetup and fold the one line left in common_gyp_vars into its only caller. BUG=330631 R=torne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248748

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : git cl web #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -32 lines) Patch
D build/all_android.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
M build/android/envsetup_functions.sh View 1 2 2 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
6 years, 10 months ago (2014-02-04 15:33:59 UTC) #1
Nico
(slightly increased this in scope in patch set 3)
6 years, 10 months ago (2014-02-04 16:07:01 UTC) #2
Torne
lgtm
6 years, 10 months ago (2014-02-04 16:24:36 UTC) #3
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 10 months ago (2014-02-04 16:35:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/150903005/80001
6 years, 10 months ago (2014-02-04 16:35:59 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 17:44:25 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=256643
6 years, 10 months ago (2014-02-04 17:44:25 UTC) #7
Nico
6 years, 10 months ago (2014-02-04 17:59:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r248748 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698