Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1509023003: MD Settings: Move width CSS property at the page level. (Closed)

Created:
5 years ago by dpapad
Modified:
5 years ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Move width CSS property at the page level. Currently the width CSS property is at the settings-section (specifically to paper-material) level. Moving it up to the page level allows properly sizing child elements that are not paper-material instances (such as the reset settings banner). BUG=425627 Committed: https://crrev.com/32bfd21b9881ed1185612039701c1e4c0df04041 Cr-Commit-Position: refs/heads/master@{#363897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/settings/advanced_page/advanced_page.css View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/basic_page/basic_page.css View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_section.css View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
dpapad
See screenshot with reset banner (which will be added in later CL), http://imgur.com/zAk5lKW. This CL ...
5 years ago (2015-12-08 23:20:48 UTC) #4
dschuyler
lgtm
5 years ago (2015-12-08 23:27:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509023003/1
5 years ago (2015-12-08 23:43:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 01:56:40 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-09 01:57:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32bfd21b9881ed1185612039701c1e4c0df04041
Cr-Commit-Position: refs/heads/master@{#363897}

Powered by Google App Engine
This is Rietveld 408576698