Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: src/ast/ast.cc

Issue 1508933004: [es6] support AssignmentPattern as LHS in for-in/of loops (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Further fixups Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/parsing/parser.h » ('j') | src/parsing/parser.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast.cc
diff --git a/src/ast/ast.cc b/src/ast/ast.cc
index b8ed4a287fab5121951e7adfc49f1ad2f85190d1..29a7b2d71c13e508eeb40637a2860120d3723fef 100644
--- a/src/ast/ast.cc
+++ b/src/ast/ast.cc
@@ -137,7 +137,9 @@ static void AssignVectorSlots(Expression* expr, FeedbackVectorSpec* spec,
void ForEachStatement::AssignFeedbackVectorSlots(
Isolate* isolate, FeedbackVectorSpec* spec,
FeedbackVectorSlotCache* cache) {
- AssignVectorSlots(each(), spec, &each_slot_);
+ if (each()->IsValidReferenceExpression()) {
adamk 2015/12/10 20:08:15 Do you still need this check?
caitp (gmail) 2015/12/10 20:32:25 I can avoid needing it, but it means an extra vari
adamk 2015/12/10 23:03:31 A TODO to further separate ForIn and ForOf here wo
caitp (gmail) 2015/12/10 23:18:16 TODO() added
+ AssignVectorSlots(each(), spec, &each_slot_);
+ }
}
« no previous file with comments | « no previous file | src/parsing/parser.h » ('j') | src/parsing/parser.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698