Fix posix IPC channel hanging problem.

Fix posix IPC channel hanging problem.

If a channel closes right before a send call, listeners might not be notified of
the problem, which can cause hangs. This CL fixes that and adds a test that makes
sure that this does not happen in the future.

This is cl/30133002 + a memory leak fix.

BUG=338709
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250964

[cpu_(ooo_6.6-7.5), 2014-01-31 21:41:12]

I'll rubberstamp whatever shess is happy with.

[Scott Hess - ex-Googler, 2014-02-03 21:45:48]

On 2014/01/31 21:41:12, cpu wrote:
> I'll rubberstamp whatever shess is happy with.

looking...

[Scott Hess - ex-Googler, 2014-02-03 22:00:26]

LGTM.

I do not share cpu's confidence in my review fu, though :-).

https://codereview.chromium.org/150893002/diff/1/ipc/ipc_channel_posix.cc
File ipc/ipc_channel_posix.cc (right):

https://codereview.chromium.org/150893002/diff/1/ipc/ipc_channel_posix.cc#new...
ipc/ipc_channel_posix.cc:526: #endif  // IPC_MESSAGE_LOG_ENABLED
Is there any problem having this above the above check?

On the one hand, the message isn't being sent, so logging that the message was
sent seems wrong.  On the other hand, the code below also allows for cases where
the message isn't actually being sent, so maybe it's logging that the message
was passed to Send().

[hubbe, 2014-02-04 19:13:38]

PTAL

https://codereview.chromium.org/150893002/diff/1/ipc/ipc_channel_posix.cc
File ipc/ipc_channel_posix.cc (right):

https://codereview.chromium.org/150893002/diff/1/ipc/ipc_channel_posix.cc#new...
ipc/ipc_channel_posix.cc:526: #endif  // IPC_MESSAGE_LOG_ENABLED
No problem - done.

On 2014/02/03 22:00:26, shess wrote:
> Is there any problem having this above the above check?
> 
> On the one hand, the message isn't being sent, so logging that the message was
> sent seems wrong.  On the other hand, the code below also allows for cases
where
> the message isn't actually being sent, so maybe it's logging that the message
> was passed to Send().

[Scott Hess - ex-Googler, 2014-02-04 19:18:00]

Still LGTM.

Thanks for paying attention to this kind of terrifying stuff.

[hubbe, 2014-02-04 19:20:17]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2014-02-04 19:24:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hubbe@chromium.org/150893002/80001

[commit-bot: I haz the power, 2014-02-04 19:58:01]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2014-02-04 20:01:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hubbe@chromium.org/150893002/80001

[hubbe1, 2014-02-04 20:14:44]

cpu?



On Tue, Feb 4, 2014 at 12:01 PM, <commit-bot@chromium.org> wrote:

> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/hubbe@chromium.org/150893002/80001
>
>
> https://codereview.chromium.org/150893002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-02-04 20:37:06]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2014-02-04 20:43:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hubbe@chromium.org/150893002/80001

[commit-bot: I haz the power, 2014-02-04 22:52:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 22:52:39]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[hubbe, 2014-02-12 22:19:56]

On 2014/02/04 22:52:39, I haz the power (commit-bot) wrote:
> Retried try job too often on chromium_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

Ping, cpu, I still need your approval to check this in.

[cpu_(ooo_6.6-7.5), 2014-02-13 02:44:35]

lgtm

[cpu_(ooo_6.6-7.5), 2014-02-13 02:44:39]

The CQ bit was checked by cpu@chromium.org

[commit-bot: I haz the power, 2014-02-13 02:45:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hubbe@chromium.org/150893002/80001

[commit-bot: I haz the power, 2014-02-13 05:38:04]

Change committed as 250964

[hubbe, 2014-02-18 17:41:44]

A revert of this CL has been created in
https://codereview.chromium.org/170863002/ by hubbe@chromium.org.

The reason for reverting is:
https://crash.corp.google.com/samples?q=reportid=%2702eaaf63ed6fdda9%27
https://crash.corp.google.com/samples?q=reportid=%272ac5bc4dd7c49ced%27.