Use proper namespace in skia/ext

Use proper namespace in skia/ext

The code was cut and pasted and kept its old namespace.

Remove SkPointToCGPoint and CGPointToSkPoint, which were not used anywhere.

BUG=561010
Committed: https://crrev.com/66142aeb157633e07f84a4eb792a9c87f2149172
Cr-Commit-Position: refs/heads/master@{#364427}

[scroggo, 2015-12-07 22:10:26]

scroggo@google.com changed reviewers:
+ mtklein@chromium.org

[tomhudson, 2015-12-07 22:13:46]

tomhudson@google.com changed reviewers:
+ tomhudson@google.com

[tomhudson, 2015-12-07 22:13:46]

Did this actually build? There are any number of callers that explicitly use
gfx:: and will need to be changed to skia::, e.g.
https://code.google.com/p/chromium/codesearch#search/&q=SkMatrixToCGAffineTra...
both skia/ext and third_party/WebKit.

Happily a purely mechanical rename should be able to be TBR'd; I've been doing
that for the CLs that led me to notice this bug.

[mtklein_C, 2015-12-07 22:13:54]

mtklein@chromium.org changed reviewers:
- tomhudson@google.com

[mtklein_C, 2015-12-07 22:13:54]

https://codereview.chromium.org/1508893003/diff/1/skia/ext/skia_utils_mac.mm
File skia/ext/skia_utils_mac.mm (right):

https://codereview.chromium.org/1508893003/diff/1/skia/ext/skia_utils_mac.mm#...
skia/ext/skia_utils_mac.mm:87: namespace skia {
If this is the only change we're making, how does the rest of the code compile?
Presumably we need to update the .h and all callers?

[scroggo, 2015-12-08 22:22:10]

Description was changed from

==========
Use proper namespace in skia/ext

The code was cut and pasted and kept its old namespace.

BUG=561010
==========

to

==========
Use proper namespace in skia/ext

The code was cut and pasted and kept its old namespace.

Remove SkPointToCGPoint and CGPointToSkPoint, which were not used anywhere.

BUG=561010
==========

[scroggo, 2015-12-08 23:11:17]

scroggo@google.com changed reviewers:
+ avi@chromium.org, jam@chromium.org, rohitrao@chromium.org, thakis@chromium.org

[scroggo, 2015-12-08 23:11:17]

Adding OWNERS

https://codereview.chromium.org/1508893003/diff/1/skia/ext/skia_utils_mac.mm
File skia/ext/skia_utils_mac.mm (right):

https://codereview.chromium.org/1508893003/diff/1/skia/ext/skia_utils_mac.mm#...
skia/ext/skia_utils_mac.mm:87: namespace skia {
On 2015/12/07 22:13:54, mtklein_C wrote:
> If this is the only change we're making, how does the rest of the code
compile?
> Presumably we need to update the .h and all callers?

I was overeager. I was relying on the bots to make it compile (since I do not
have a mac setup for building chromium). They have shown me where I need to
update call sites.

[mtklein_C, 2015-12-08 23:14:07]

lgtm

[jam, 2015-12-08 23:58:47]

On 2015/12/08 23:11:17, scroggo wrote:
> Adding OWNERS

please call out which reviewers need to look at which parts

[Avi (use Gerrit), 2015-12-09 00:57:12]

This all lgtm.

[scroggo, 2015-12-09 16:06:14]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2015-12-09 16:07:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508893003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508893003/40001

[commit-bot: I haz the power, 2015-12-09 16:13:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 16:13:52]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nico, 2015-12-09 16:39:36]

lgtm2

[scroggo, 2015-12-10 14:17:53]

The CQ bit was checked by scroggo@google.com

[scroggo, 2015-12-10 14:17:53]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
mtklein@chromium.org
Link to the patchset: https://codereview.chromium.org/1508893003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-12-10 14:18:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508893003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508893003/60001

[commit-bot: I haz the power, 2015-12-10 14:34:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 14:34:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[scroggo, 2015-12-10 14:53:18]

scroggo@google.com changed reviewers:
+ mathp@chromium.org, pkotwicz@chromium.org

[scroggo, 2015-12-10 14:53:18]

pkotwicz@, will you please provide OWNERS review for
chrome/browser/themes/theme_service_mac.mm

mathp@, will you please provide OWNERS review
forcomponents/suggestions/image_encoder_ios.mm and
ios/chrome/browser/suggestions/image_fetcher_impl.mm

Nico, thanks for your support, but it looks like "lgtm2" does not qualify for
the third_party/WebKit files. Will you please "lgtm"?

[Mathieu, 2015-12-10 15:10:42]

suggestions lgtm

[Nico, 2015-12-10 15:29:10]

lgtm

sorry :-(

[Nico, 2015-12-10 15:29:28]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-12-10 15:30:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508893003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508893003/60001

[commit-bot: I haz the power, 2015-12-10 17:23:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 17:23:20]

Failed to apply patch for ui/views/cocoa/bridged_content_view.mm:
While running git apply --index -3 -p1;
  error: patch failed: ui/views/cocoa/bridged_content_view.mm:313
  Falling back to three-way merge...
  Applied patch to 'ui/views/cocoa/bridged_content_view.mm' with conflicts.
  U ui/views/cocoa/bridged_content_view.mm

Patch:       ui/views/cocoa/bridged_content_view.mm
Index: ui/views/cocoa/bridged_content_view.mm
diff --git a/ui/views/cocoa/bridged_content_view.mm
b/ui/views/cocoa/bridged_content_view.mm
index
82c40dd171912a76f807332895c6fac6d04ab370..2167561368c38f1b8a637d99c1b1daa022faae15
100644
--- a/ui/views/cocoa/bridged_content_view.mm
+++ b/ui/views/cocoa/bridged_content_view.mm
@@ -313,7 +313,7 @@ bool DispatchEventToMenu(views::Widget* widget,
ui::KeyboardCode key_code) {
 
   if (drawMenuBackgroundForBlur_) {
     const CGFloat radius = views::MenuConfig::instance().corner_radius;
-    [gfx::SkColorToSRGBNSColor(0x01000000) set];
+    [skia::SkColorToSRGBNSColor(0x01000000) set];
     [[NSBezierPath bezierPathWithRoundedRect:[self bounds]
                                      xRadius:radius
                                      yRadius:radius] fill];

[commit-bot: I haz the power, 2015-12-10 17:24:07]

The CQ bit was unchecked by commit-bot@chromium.org

[scroggo, 2015-12-10 17:35:30]

The CQ bit was checked by scroggo@google.com

[scroggo, 2015-12-10 17:35:31]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
mtklein@chromium.org, mathp@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1508893003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-12-10 17:37:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508893003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508893003/80001

[commit-bot: I haz the power, 2015-12-10 19:39:48]

Description was changed from

==========
Use proper namespace in skia/ext

The code was cut and pasted and kept its old namespace.

Remove SkPointToCGPoint and CGPointToSkPoint, which were not used anywhere.

BUG=561010
==========

to

==========
Use proper namespace in skia/ext

The code was cut and pasted and kept its old namespace.

Remove SkPointToCGPoint and CGPointToSkPoint, which were not used anywhere.

BUG=561010
==========

[commit-bot: I haz the power, 2015-12-10 19:39:50]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-10 19:40:40]

Description was changed from

==========
Use proper namespace in skia/ext

The code was cut and pasted and kept its old namespace.

Remove SkPointToCGPoint and CGPointToSkPoint, which were not used anywhere.

BUG=561010
==========

to

==========
Use proper namespace in skia/ext

The code was cut and pasted and kept its old namespace.

Remove SkPointToCGPoint and CGPointToSkPoint, which were not used anywhere.

BUG=561010

Committed: https://crrev.com/66142aeb157633e07f84a4eb792a9c87f2149172
Cr-Commit-Position: refs/heads/master@{#364427}
==========

[commit-bot: I haz the power, 2015-12-10 19:40:41]

Patchset 5 (id:??) landed as
https://crrev.com/66142aeb157633e07f84a4eb792a9c87f2149172
Cr-Commit-Position: refs/heads/master@{#364427}