Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1508853004: Revert "Roll AppRTC 3168981..e7f6cae" (Closed)

Created:
5 years ago by kjellander_chromium
Modified:
5 years ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Roll AppRTC 3168981..e7f6cae" This reverts commit bb14af8a299248d1471d4cfc5b63922297665fea in https://codereview.chromium.org/1509873002/ Reason: collider fails to build: ________ running '/usr/bin/python webrtc.DEPS/build_apprtc_collider.py' in '/mnt/data/b/build/slave/Linux_Builder/build' src/out/go-workspace/src/collider/collider.go:55: undefined: tls.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 src/out/go-workspace/src/collider/collider.go:59: undefined: tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 Traceback (most recent call last): File "webrtc.DEPS/build_apprtc_collider.py", line 43, in <module> sys.exit(main()) File "webrtc.DEPS/build_apprtc_collider.py", line 38, in main env=golang_env) File "/usr/lib/python2.7/subprocess.py", line 511, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['go/bin/go', 'get', 'collidermain']' returned non-zero exit status 2 Error: Command '/usr/bin/python webrtc.DEPS/build_apprtc_collider.py' returned non-zero exit status 1 in /mnt/data/b/build/slave/Linux_Builder/build BUG=567598 TBR=phoglund@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS/+/b1aa63845a4ff9cbde89f5fa503b27cc77d5e4aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
kjellander_chromium
5 years ago (2015-12-08 13:13:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b1aa63845a4ff9cbde89f5fa503b27cc77d5e4aa (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698