Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 150883002: Revert of Fix posix IPC channel hanging problem. (Closed)

Created:
6 years, 10 months ago by hubbe
Modified:
6 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Fredrik Öhrn
Visibility:
Public.

Description

Revert of Fix posix IPC channel hanging problem. (https://codereview.chromium.org/30133002/) Reason for revert: Seems to cause some leaks. Reverting while I investigate. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%282%29/builds/22398 Original issue's description: > Fix posix IPC channel hanging problem. > > If a channel closes right before a send call, listeners might not be notified of > the problem, which can cause hangs. This CL fixes that and adds a test that makes > sure that this does not happen in the future. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248060 TBR=cpu@chromium.org,shess@chromium.org,hubbe@google.com NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -64 lines) Patch
M ipc/ipc_channel_posix.cc View 5 chunks +3 lines, -14 lines 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 4 chunks +3 lines, -50 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hubbe
Created Revert of Fix posix IPC channel hanging problem.
6 years, 10 months ago (2014-01-30 22:59:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/150883002/1
6 years, 10 months ago (2014-01-30 22:59:56 UTC) #2
commit-bot: I haz the power
Change committed as 248067
6 years, 10 months ago (2014-01-30 23:00:41 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 23:00:42 UTC) #4
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698