Fix NPE when favicon is updated.

Fix NPE when favicon is updated.

BUG=567299
Committed: https://crrev.com/1353bd527c32e7686c7a238cc5ddffec87afb959
Cr-Commit-Position: refs/heads/master@{#364494}

[Peter Wen, 2015-12-07 19:53:01]

wnwen@chromium.org changed reviewers:
+ yusufo@chromium.org

[Yusuf, 2015-12-07 21:58:21]

Thanks for looking into this!

I think the null check should be in Tab.java where the observer method is called
from though. There is another icon. reference there and looks like this avoided
it because of the way the conditional is built.

So onFaviconAvailable should have an early return for icon==null.

[Peter Wen, 2015-12-07 22:16:01]

Added. PTAL. :)

[Yusuf, 2015-12-08 00:14:58]

https://codereview.chromium.org/1504183003/ also addresses this and looks like
we also need an updateTaskDescription call in DocumentActivity

[Peter Wen, 2015-12-08 18:09:05]

On 2015/12/08 00:14:58, Yusuf wrote:
> https://codereview.chromium.org/1504183003/ also addresses this and looks like
> we also need an updateTaskDescription call in DocumentActivity

Seems this CL is now just a one-line guard. :)

[Peter Wen, 2015-12-10 15:20:45]

Friendly ping. PTAL. :)

[Yusuf, 2015-12-10 18:49:43]

lgtm

[Peter Wen, 2015-12-10 19:44:57]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2015-12-10 19:46:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508813002/40001

[commit-bot: I haz the power, 2015-12-10 19:58:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 19:58:57]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Peter Wen, 2015-12-10 20:50:45]

wnwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Peter Wen, 2015-12-10 20:50:46]

+dfalcantara@ for OWNERs.

[gone, 2015-12-10 20:55:32]

lgtm

[Peter Wen, 2015-12-10 21:04:13]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2015-12-10 21:09:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508813002/40001

[commit-bot: I haz the power, 2015-12-10 22:00:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-10 22:02:00]

Description was changed from

==========
Fix NPE when favicon is updated.

BUG=567299
==========

to

==========
Fix NPE when favicon is updated.

BUG=567299

Committed: https://crrev.com/1353bd527c32e7686c7a238cc5ddffec87afb959
Cr-Commit-Position: refs/heads/master@{#364494}
==========

[commit-bot: I haz the power, 2015-12-10 22:02:00]

Patchset 3 (id:??) landed as
https://crrev.com/1353bd527c32e7686c7a238cc5ddffec87afb959
Cr-Commit-Position: refs/heads/master@{#364494}