Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: src/heap/objects-visiting-inl.h

Issue 1508703002: Use WeakCells in the optimized code map rather than traversing in pause. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed nit. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/objects-visiting.h ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/objects-visiting-inl.h
diff --git a/src/heap/objects-visiting-inl.h b/src/heap/objects-visiting-inl.h
index 8e96f339bdca230bb9f088d49a8a58673b30b654..a29ba4b08cc9bc9c6d4401a01f7259946beb6f13 100644
--- a/src/heap/objects-visiting-inl.h
+++ b/src/heap/objects-visiting-inl.h
@@ -454,14 +454,6 @@ void StaticMarkingVisitor<StaticVisitor>::VisitSharedFunctionInfo(
// Always flush the optimized code map if requested by flag.
shared->ClearOptimizedCodeMap();
}
- } else {
- if (!shared->OptimizedCodeMapIsCleared()) {
- // Treat some references within the code map weakly by marking the
- // code map itself but not pushing it onto the marking deque. The
- // map will be processed after marking.
- FixedArray* code_map = shared->optimized_code_map();
- MarkOptimizedCodeMap(heap, code_map);
- }
}
MarkCompactCollector* collector = heap->mark_compact_collector();
if (collector->is_code_flushing_enabled()) {
@@ -578,23 +570,6 @@ void StaticMarkingVisitor<StaticVisitor>::MarkMapContents(Heap* heap,
}
-template <typename StaticVisitor>
-void StaticMarkingVisitor<StaticVisitor>::MarkOptimizedCodeMap(
- Heap* heap, FixedArray* code_map) {
- if (!StaticVisitor::MarkObjectWithoutPush(heap, code_map)) return;
-
- // Mark the context-independent entry in the optimized code map. Depending on
- // the age of the code object, we treat it as a strong or a weak reference.
- Object* shared_object = code_map->get(SharedFunctionInfo::kSharedCodeIndex);
- if (FLAG_turbo_preserve_shared_code && shared_object->IsCode() &&
- FLAG_age_code && !Code::cast(shared_object)->IsOld()) {
- StaticVisitor::VisitPointer(
- heap, code_map,
- code_map->RawFieldOfElementAt(SharedFunctionInfo::kSharedCodeIndex));
- }
-}
-
-
inline static bool HasSourceCode(Heap* heap, SharedFunctionInfo* info) {
Object* undefined = heap->undefined_value();
return (info->script() != undefined) &&
« no previous file with comments | « src/heap/objects-visiting.h ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698