Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4302)

Unified Diff: chrome/common/extensions/docs/server2/render_servlet_test.py

Issue 15087006: Docserver: there is only one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: epic rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/render_servlet_test.py
diff --git a/chrome/common/extensions/docs/server2/render_servlet_test.py b/chrome/common/extensions/docs/server2/render_servlet_test.py
index 75c91feb01ac8363a4689fb368af216595148539..f1886716dcfc3f609816dc75706e807e2e72523a 100755
--- a/chrome/common/extensions/docs/server2/render_servlet_test.py
+++ b/chrome/common/extensions/docs/server2/render_servlet_test.py
@@ -8,23 +8,25 @@ import unittest
from local_file_system import LocalFileSystem
from render_servlet import RenderServlet
from server_instance import ServerInstance
-from servlet import Request
+from servlet import Request, Response
from test_util import DisableLogging, ReadFile
class _RenderServletDelegate(RenderServlet.Delegate):
- def CreateServerInstanceForChannel(self, channel):
+ def CreateServerInstance(self):
return ServerInstance.ForTest(LocalFileSystem.Create())
class RenderServletTest(unittest.TestCase):
def testExtensionAppRedirect(self):
request = Request.ForTest('storage.html')
- response = RenderServlet(request, _RenderServletDelegate()).Get()
- self.assertEqual(302, response.status)
+ self.assertEqual(
+ Response.Redirect('/extensions/storage.html', permanent=False),
+ RenderServlet(request, _RenderServletDelegate()).Get())
- def testDefaultChannel(self):
+ def testChannelRedirect(self):
request = Request.ForTest('stable/extensions/storage.html')
- response = RenderServlet(request, _RenderServletDelegate()).Get()
- self.assertEqual(302, response.status)
+ self.assertEqual(
+ Response.Redirect('/extensions/storage.html', permanent=True),
+ RenderServlet(request, _RenderServletDelegate()).Get())
@DisableLogging('warning')
def testNotFound(self):
« no previous file with comments | « chrome/common/extensions/docs/server2/render_servlet.py ('k') | chrome/common/extensions/docs/server2/rietveld_patcher.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698