Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/common/extensions/docs/server2/patch_servlet.py

Issue 15087006: Docserver: there is only one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: better redirects Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from fnmatch import fnmatch 5 from fnmatch import fnmatch
6 import logging 6 import logging
7 from urlparse import urlparse 7 from urlparse import urlparse
8 8
9 from appengine_url_fetcher import AppEngineUrlFetcher 9 from appengine_url_fetcher import AppEngineUrlFetcher
10 from appengine_wrappers import IsDevServer 10 from appengine_wrappers import IsDevServer
11 from caching_file_system import CachingFileSystem 11 from caching_file_system import CachingFileSystem
12 from caching_rietveld_patcher import CachingRietveldPatcher 12 from caching_rietveld_patcher import CachingRietveldPatcher
13 from chained_compiled_file_system import ChainedCompiledFileSystem 13 from chained_compiled_file_system import ChainedCompiledFileSystem
14 from compiled_file_system import CompiledFileSystem 14 from compiled_file_system import CompiledFileSystem
15 from instance_servlet import InstanceServlet 15 from instance_servlet import InstanceServlet
16 from render_servlet import RenderServlet 16 from render_servlet import RenderServlet
17 from rietveld_patcher import RietveldPatcher, RietveldPatcherError 17 from rietveld_patcher import RietveldPatcher, RietveldPatcherError
18 from object_store_creator import ObjectStoreCreator 18 from object_store_creator import ObjectStoreCreator
19 from patched_file_system import PatchedFileSystem 19 from patched_file_system import PatchedFileSystem
20 from server_instance import ServerInstance 20 from server_instance import ServerInstance
21 from servlet import Request, Response, Servlet 21 from servlet import Request, Response, Servlet
22 import svn_constants 22 import svn_constants
23 import url_constants 23 import url_constants
24 24
25 class _PatchServletDelegate(RenderServlet.Delegate): 25 class _PatchServletDelegate(RenderServlet.Delegate):
26 def __init__(self, issue, delegate): 26 def __init__(self, issue, delegate):
27 self._issue = issue 27 self._issue = issue
28 self._delegate = delegate 28 self._delegate = delegate
29 29
30 def CreateServerInstanceForChannel(self, channel): 30 def CreateServerInstance(self):
31 base_object_store_creator = ObjectStoreCreator(channel, 31 object_store_creator = ObjectStoreCreator(start_empty=False)
32 start_empty=False)
33 # TODO(fj): Use OfflineFileSystem here once all json/idl files in api/ 32 # TODO(fj): Use OfflineFileSystem here once all json/idl files in api/
34 # are pulled into data store by cron jobs. 33 # are pulled into data store by cron jobs.
35 base_file_system = CachingFileSystem( 34 base_file_system = CachingFileSystem(self._delegate.CreateHostFileSystem(),
36 self._delegate.CreateHostFileSystemForBranch(channel), 35 object_store_creator)
37 base_object_store_creator) 36 base_compiled_fs_factory = CompiledFileSystem.Factory(base_file_system,
38 base_compiled_fs_factory = CompiledFileSystem.Factory( 37 object_store_creator)
39 base_file_system, base_object_store_creator)
40 38
41 object_store_creator = ObjectStoreCreator('trunk@%s' % self._issue,
42 start_empty=False)
43 rietveld_patcher = CachingRietveldPatcher( 39 rietveld_patcher = CachingRietveldPatcher(
44 RietveldPatcher(svn_constants.EXTENSIONS_PATH, 40 RietveldPatcher(svn_constants.EXTENSIONS_PATH,
45 self._issue, 41 self._issue,
46 AppEngineUrlFetcher(url_constants.CODEREVIEW_SERVER)), 42 AppEngineUrlFetcher(url_constants.CODEREVIEW_SERVER)),
47 object_store_creator) 43 object_store_creator)
48 patched_file_system = PatchedFileSystem(base_file_system, 44 patched_file_system = PatchedFileSystem(base_file_system,
49 rietveld_patcher) 45 rietveld_patcher)
50 patched_compiled_fs_factory = CompiledFileSystem.Factory( 46 patched_compiled_fs_factory = CompiledFileSystem.Factory(
51 patched_file_system, object_store_creator) 47 patched_file_system, object_store_creator)
52 48
53 compiled_fs_factory = ChainedCompiledFileSystem.Factory( 49 compiled_fs_factory = ChainedCompiledFileSystem.Factory(
54 [(patched_compiled_fs_factory, patched_file_system), 50 [(patched_compiled_fs_factory, patched_file_system),
55 (base_compiled_fs_factory, base_file_system)]) 51 (base_compiled_fs_factory, base_file_system)])
56 return ServerInstance(channel, 52 return ServerInstance(object_store_creator,
57 object_store_creator,
58 patched_file_system, 53 patched_file_system,
59 self._delegate.CreateAppSamplesFileSystem( 54 self._delegate.CreateAppSamplesFileSystem(
60 base_object_store_creator), 55 object_store_creator),
61 '/_patch/%s/static' % self._issue, 56 compiled_fs_factory,
62 compiled_fs_factory) 57 '/_patch/%s/static' % self._issue)
63 58
64 class PatchServlet(Servlet): 59 class PatchServlet(Servlet):
65 '''Servlet which renders patched docs. 60 '''Servlet which renders patched docs.
66 ''' 61 '''
67 def __init__(self, request, delegate=None): 62 def __init__(self, request, delegate=None):
68 self._request = request 63 self._request = request
69 self._delegate = delegate or InstanceServlet.Delegate() 64 self._delegate = delegate or InstanceServlet.Delegate()
70 65
71 def Get(self): 66 def Get(self):
72 if (not IsDevServer() and 67 if (not IsDevServer() and
73 not fnmatch(urlparse(self._request.host).netloc, '*.appspot.com')): 68 not fnmatch(urlparse(self._request.host).netloc, '*.appspot.com')):
74 # Only allow patches on appspot URLs; it doesn't matter if appspot.com is 69 # Only allow patches on appspot URLs; it doesn't matter if appspot.com is
75 # XSS'ed, but it matters for chrome.com. 70 # XSS'ed, but it matters for chrome.com.
76 redirect_host = 'https://chrome-apps-doc.appspot.com' 71 redirect_host = 'https://chrome-apps-doc.appspot.com'
77 logging.info('Redirecting from XSS-able host %s to %s' % ( 72 logging.info('Redirecting from XSS-able host %s to %s' % (
78 self._request.host, redirect_host)) 73 self._request.host, redirect_host))
79 return Response.Redirect( 74 return Response.Redirect(
80 '%s/_patch/%s' % (redirect_host, self._request.path)) 75 '%s/_patch/%s' % (redirect_host, self._request.path))
81 76
82 path_with_issue = self._request.path.lstrip('/') 77 path_with_issue = self._request.path.lstrip('/')
83 if '/' in path_with_issue: 78 if '/' in path_with_issue:
84 issue, real_path = path_with_issue.split('/', 1) 79 issue, path_without_issue = path_with_issue.split('/', 1)
85 else: 80 else:
86 return Response.NotFound('Malformed URL. It should look like ' + 81 return Response.NotFound('Malformed URL. It should look like ' +
87 'https://developer.chrome.com/_patch/12345/extensions/...') 82 'https://developer.chrome.com/_patch/12345/extensions/...')
88 83
89 fake_path = '/trunk/%s' % real_path
90
91 try: 84 try:
92 response = RenderServlet( 85 response = RenderServlet(
93 Request(fake_path, self._request.host, self._request.headers), 86 Request(path_without_issue,
87 self._request.host,
88 self._request.headers),
94 _PatchServletDelegate(issue, self._delegate)).Get() 89 _PatchServletDelegate(issue, self._delegate)).Get()
95 # Disable cache for patched content. 90 # Disable cache for patched content.
96 response.headers.pop('cache-control', None) 91 response.headers.pop('cache-control', None)
97 except RietveldPatcherError as e: 92 except RietveldPatcherError as e:
98 response = Response.NotFound(e.message, {'Content-Type': 'text/plain'}) 93 response = Response.NotFound(e.message, {'Content-Type': 'text/plain'})
99 94
100 redirect_url, permanent = response.GetRedirect() 95 redirect_url, permanent = response.GetRedirect()
101 if redirect_url is not None: 96 if redirect_url is not None:
102 if redirect_url.startswith('/trunk/'):
103 redirect_url = redirect_url.split('/trunk', 1)[1]
104 response = Response.Redirect('/_patch/%s%s' % (issue, redirect_url), 97 response = Response.Redirect('/_patch/%s%s' % (issue, redirect_url),
105 permanent) 98 permanent)
106 return response 99 return response
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698