Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h

Issue 1508683002: DeferredImageDecoder: early-out onGetYUV8Planes when possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix canYUVDecode enable logic Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h
diff --git a/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h b/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h
index 9a9ac40b4cbe9e356c656b1bc2edaf935b9225fb..eb2c2da3be34bbd27b2ca211e3a84fe7d8b8812f 100644
--- a/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h
+++ b/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.h
@@ -46,12 +46,13 @@ class PLATFORM_EXPORT DecodingImageGenerator final : public SkImageGenerator {
USING_FAST_MALLOC(DecodingImageGenerator);
WTF_MAKE_NONCOPYABLE(DecodingImageGenerator);
public:
- static SkImageGenerator* create(SkData*);
-
DecodingImageGenerator(PassRefPtr<ImageFrameGenerator>, const SkImageInfo&, size_t index);
~DecodingImageGenerator() override;
void setGenerationId(size_t id) { m_generationId = id; }
+ void setCanYUVDecode(bool yes) { m_canYUVDecode = yes; }
+
+ static SkImageGenerator* create(SkData*); // Highly unsual access.
scroggo_chromium 2015/12/07 16:40:02 unusual* Is the goal of this comment to say somet
Noel Gordon 2015/12/08 01:40:08 The goal was just to point it out, to you, since i
protected:
SkData* onRefEncodedData() override;
@@ -64,6 +65,7 @@ private:
RefPtr<ImageFrameGenerator> m_frameGenerator;
size_t m_frameIndex;
size_t m_generationId;
+ bool m_canYUVDecode;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698