Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1242)

Issue 1508653002: [debugger] add test case for stepping into proxy traps. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] add test case for stepping into proxy traps. R=jkummerow@chromium.org Committed: https://crrev.com/a607ec84d5efbe3c53ec86bd0eb1bf98d9410395 Cr-Commit-Position: refs/heads/master@{#32671}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
A test/mjsunit/harmony/debug-stepin-proxies.js View 1 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yang
5 years ago (2015-12-07 10:46:00 UTC) #1
Jakob Kummerow
LGTM with nit https://codereview.chromium.org/1508653002/diff/1/test/mjsunit/harmony/debug-stepin-proxies.js File test/mjsunit/harmony/debug-stepin-proxies.js (right): https://codereview.chromium.org/1508653002/diff/1/test/mjsunit/harmony/debug-stepin-proxies.js#newcode64 test/mjsunit/harmony/debug-stepin-proxies.js:64: print(JSON.stringify(log)); nit: leftover?
5 years ago (2015-12-07 10:51:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508653002/20001
5 years ago (2015-12-08 05:22:22 UTC) #5
Yang
On 2015/12/07 10:51:03, Jakob wrote: > LGTM with nit > > https://codereview.chromium.org/1508653002/diff/1/test/mjsunit/harmony/debug-stepin-proxies.js > File test/mjsunit/harmony/debug-stepin-proxies.js ...
5 years ago (2015-12-08 05:22:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-08 07:10:41 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-08 07:10:59 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a607ec84d5efbe3c53ec86bd0eb1bf98d9410395
Cr-Commit-Position: refs/heads/master@{#32671}

Powered by Google App Engine
This is Rietveld 408576698