[turbofan] Don't try to inling dead nodes.

[turbofan] Don't try to inling dead nodes.

The JSInliningHeuristic keeps a list of nodes, which might have been
killed by other reducers before the JSInliningHeuristic looks at it
again, so it has to check whether nodes are dead before trying to
expand them later (this is similar to what the ValueNumberingReducer
needs to do with its internal table).

R=mstarzinger@chromium.org

Committed: https://crrev.com/1c44aa0e8dddf95448f7f52b78cc06f7a26c8986
Cr-Commit-Position: refs/heads/master@{#32652}

[Benedikt Meurer, 2015-12-07 10:42:48]

Hey Michi,

Here's the quick fix for dead nodes in the JSInliner.
Please take a look.

Thanks,
Benedikt

[Michael Starzinger, 2015-12-07 10:50:49]

LGTM.

https://codereview.chromium.org/1508643002/diff/1/src/compiler/js-inlining-he...
File src/compiler/js-inlining-heuristic.cc (right):

https://codereview.chromium.org/1508643002/diff/1/src/compiler/js-inlining-he...
src/compiler/js-inlining-heuristic.cc:110: // Make sure we don't try to inline
dead candidate nodes.
suggestion: Could also be phrased as "if (candidate.node->IsDead()) continue",
might be more readable, but not sure, up to you.

[Benedikt Meurer, 2015-12-07 11:25:44]

https://codereview.chromium.org/1508643002/diff/1/src/compiler/js-inlining-he...
File src/compiler/js-inlining-heuristic.cc (right):

https://codereview.chromium.org/1508643002/diff/1/src/compiler/js-inlining-he...
src/compiler/js-inlining-heuristic.cc:110: // Make sure we don't try to inline
dead candidate nodes.
Had that initially, but changed it to this.

[Benedikt Meurer, 2015-12-07 11:25:48]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-12-07 11:25:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1508643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1508643002/1

[commit-bot: I haz the power, 2015-12-07 11:27:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-07 11:27:52]

Description was changed from

==========
[turbofan] Don't try to inling dead nodes.

The JSInliningHeuristic keeps a list of nodes, which might have been
killed by other reducers before the JSInliningHeuristic looks at it
again, so it has to check whether nodes are dead before trying to
expand them later (this is similar to what the ValueNumberingReducer
needs to do with its internal table).

R=mstarzinger@chromium.org
==========

to

==========
[turbofan] Don't try to inling dead nodes.

The JSInliningHeuristic keeps a list of nodes, which might have been
killed by other reducers before the JSInliningHeuristic looks at it
again, so it has to check whether nodes are dead before trying to
expand them later (this is similar to what the ValueNumberingReducer
needs to do with its internal table).

R=mstarzinger@chromium.org

Committed: https://crrev.com/1c44aa0e8dddf95448f7f52b78cc06f7a26c8986
Cr-Commit-Position: refs/heads/master@{#32652}
==========

[commit-bot: I haz the power, 2015-12-07 11:27:53]

Patchset 1 (id:??) landed as
https://crrev.com/1c44aa0e8dddf95448f7f52b78cc06f7a26c8986
Cr-Commit-Position: refs/heads/master@{#32652}