Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 150863002: android/clang: Don't add path to gold shim to PATH, use -B instead. (Closed)

Created:
6 years, 10 months ago by Nico
Modified:
6 years, 10 months ago
Reviewers:
Torne
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

android/clang: Don't add path to gold shim to PATH, use -B instead. No intended behavior change. BUG=330631 R=torne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248080

Patch Set 1 #

Patch Set 2 : doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M build/android/envsetup_functions.sh View 1 chunk +0 lines, -6 lines 0 comments Download
M build/common.gypi View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
(sending before try results since you seem to be around right now)
6 years, 10 months ago (2014-01-30 22:45:36 UTC) #1
Torne
lgtm
6 years, 10 months ago (2014-01-30 23:17:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/150863002/20001
6 years, 10 months ago (2014-01-30 23:55:20 UTC) #3
Nico
Committed patchset #2 manually as r248080.
6 years, 10 months ago (2014-01-31 00:04:39 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 00:04:39 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 00:04:42 UTC) #6
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698