Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1398)

Unified Diff: mojo/public/python/mojo_bindings/interface_reflection.py

Issue 1508613003: Require an explicit ServiceName annotation for interfaces in Python. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/python/mojo_bindings/interface_reflection.py
diff --git a/mojo/public/python/mojo_bindings/interface_reflection.py b/mojo/public/python/mojo_bindings/interface_reflection.py
index 8ce3882106ba7deb30bd3b0b562365e5fc8bebdb..b78b1775dee55da7c6cb5e641e094123ed48465d 100644
--- a/mojo/public/python/mojo_bindings/interface_reflection.py
+++ b/mojo/public/python/mojo_bindings/interface_reflection.py
@@ -67,8 +67,9 @@ class MojoInterfaceType(type):
fully_qualified_name = descriptor['fully_qualified_name']
interface_manager = InterfaceManager(
- fully_qualified_name, descriptor['version'], methods)
+ name, descriptor['version'], methods)
dictionary.update({
+ 'service_name' = fully_qualified_name,
'manager': None,
'_interface_manager': interface_manager,
})

Powered by Google App Engine
This is Rietveld 408576698