Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1508563003: Fix a potential crash in MidiManagerMac. (Closed)

Created:
5 years ago by Oliver Chang
Modified:
5 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a potential crash in MidiManagerMac. R=toyoshim@chromium.org,agoode@chromium.org BUG=564501 Committed: https://crrev.com/54d256d1fc9c6a9e7438f6f51206d1f99b1ed6b4 Cr-Commit-Position: refs/heads/master@{#363714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/midi/midi_manager_mac.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508563003/1
5 years ago (2015-12-07 20:15:38 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-07 21:40:40 UTC) #4
Oliver Chang
ptal. simple patch.
5 years ago (2015-12-08 00:17:54 UTC) #5
Takashi Toyoshima
lgtm, thanks.
5 years ago (2015-12-08 02:27:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508563003/1
5 years ago (2015-12-08 02:28:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 02:36:16 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-08 02:38:00 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/54d256d1fc9c6a9e7438f6f51206d1f99b1ed6b4
Cr-Commit-Position: refs/heads/master@{#363714}

Powered by Google App Engine
This is Rietveld 408576698