Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1508543003: Initialize the deferred global for every fragment. (Closed)

Created:
5 years ago by floitsch
Modified:
5 years ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Initialize the deferred global for every fragment. This makes it possible to concatenate commonly used fragments in front of the main fragment. For example, if an application knows that it will immediately load a fragment, it can prefix its main fragment with that fragment. R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/aae55178663ba6c128bf478de09b80177db9e737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 3 chunks +12 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 4 chunks +3 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 4 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
This is really hard to test, since it requires to concatenate the output files into ...
5 years ago (2015-12-07 23:13:00 UTC) #2
sra1
lgtm
5 years ago (2015-12-09 00:16:54 UTC) #3
floitsch
5 years ago (2015-12-09 00:21:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aae55178663ba6c128bf478de09b80177db9e737 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698