Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1508423002: MIPS: [turbofan] Use RINT instruction for Float64|32Round ops. on r6. (Closed)

Created:
5 years ago by dusan.milosavljevic
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Use RINT instruction for Float64|32Round ops. on r6. TEST= BUG= Committed: https://crrev.com/3ef18f5a91940148dd28ae026e43bb0dca5294a4 Cr-Commit-Position: refs/heads/master@{#32749}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -34 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 4 chunks +28 lines, -16 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 4 chunks +28 lines, -16 lines 0 comments Download
M src/mips/constants-mips.h View 1 chunk +6 lines, -1 line 1 comment Download
M src/mips64/constants-mips64.h View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
dusan.milosavljevic
PTAL.
5 years ago (2015-12-09 13:54:33 UTC) #2
paul.l...
Nice change! LGTM. However, I did not get a chance to run tests on this. ...
5 years ago (2015-12-10 05:39:50 UTC) #3
titzer
lgtm here
5 years ago (2015-12-10 08:19:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508423002/1
5 years ago (2015-12-10 11:51:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 12:23:44 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-10 12:24:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ef18f5a91940148dd28ae026e43bb0dca5294a4
Cr-Commit-Position: refs/heads/master@{#32749}

Powered by Google App Engine
This is Rietveld 408576698