core/src/fxge/ge/text_int.h - Issue 1508343004: Merge to master: Fix heap-use-after-free in FT_Stream_ReleaseFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/ge/text_int.h

Issue 1508343004: Merge to master: Fix heap-use-after-free in FT_Stream_ReleaseFrame (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fxge/ge/text_int.h

diff --git a/core/src/fxge/ge/text_int.h b/core/src/fxge/ge/text_int.h

index f17cf7f18f92e5dc2d21ff7300d53f1d75d7fb76..1b96cfbdd2b1149a7cb574d5284a670eb6d5ef8a 100644

--- a/core/src/fxge/ge/text_int.h

+++ b/core/src/fxge/ge/text_int.h

@@ -29,7 +29,10 @@ class CTTFontDesc {

m_RefCount = 0;

}

~CTTFontDesc();

- FX_BOOL ReleaseFace(FXFT_Face face);

+ // ret < 0, releaseface not appropriate for this object.

+ // ret == 0, object released

+ // ret > 0, object still alive, other referrers.

+ int ReleaseFace(FXFT_Face face);

int m_Type;

union {

struct {

« no previous file with comments | « core/src/fxge/ge/fx_ge_fontmap.cpp ('k') | no next file » | no next file with comments »