Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 1508343002: Static/instance getter/setter override is a warning. (Closed)

Created:
5 years ago by Johnni Winther
Modified:
5 years ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Static/instance getter/setter override is a warning. Closes #11496 R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/a48dbfefd854a64ccdae01268af829414d3ea2e8

Patch Set 1 #

Patch Set 2 : Update analyzer status + include unsaved identical => == change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M pkg/compiler/lib/src/resolution/resolution.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tests/language/language_analyzer.status View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
5 years ago (2015-12-09 09:11:55 UTC) #2
karlklose
LGTM, but the bug is still referenced from analyzer status files. Please check, if these ...
5 years ago (2015-12-09 10:15:03 UTC) #3
Johnni Winther
5 years ago (2015-12-09 10:57:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a48dbfefd854a64ccdae01268af829414d3ea2e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698