Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 1508313004: Change google3 sync scripts to sync latest rather than LKGR. (Closed)

Created:
5 years ago by dogben
Modified:
5 years ago
Reviewers:
mtklein
CC:
jcgregorio, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Change google3 sync scripts to sync latest rather than LKGR. This matches the behavior of the autoroller and is generally more useful. BUG=skia: Committed: https://skia.googlesource.com/skia/+/0ff46c06b7035ca66a1a459f21160f1d5ba7fcb2

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove LKGR support. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -39 lines) Patch
D tools/get_skia_lkgr.sh View 1 1 chunk +0 lines, -24 lines 0 comments Download
M tools/git_clone_to_google3.sh View 1 1 chunk +5 lines, -6 lines 0 comments Download
M tools/sync_google3.sh View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dogben
5 years ago (2015-12-10 18:02:07 UTC) #2
mtklein
https://codereview.chromium.org/1508313004/diff/1/tools/git_clone_to_google3.sh File tools/git_clone_to_google3.sh (right): https://codereview.chromium.org/1508313004/diff/1/tools/git_clone_to_google3.sh#newcode30 tools/git_clone_to_google3.sh:30: elif [[ "${FLAGS_skia_rev}" =~ "[Ll][Kk][Gg][Rr]" ]]; then I agree ...
5 years ago (2015-12-10 18:09:07 UTC) #3
mtklein
(as-is also lgtm)
5 years ago (2015-12-10 18:10:00 UTC) #4
dogben
https://codereview.chromium.org/1508313004/diff/1/tools/git_clone_to_google3.sh File tools/git_clone_to_google3.sh (right): https://codereview.chromium.org/1508313004/diff/1/tools/git_clone_to_google3.sh#newcode30 tools/git_clone_to_google3.sh:30: elif [[ "${FLAGS_skia_rev}" =~ "[Ll][Kk][Gg][Rr]" ]]; then On 2015/12/10 ...
5 years ago (2015-12-10 18:18:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508313004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508313004/20001
5 years ago (2015-12-11 19:12:47 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-11 19:26:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0ff46c06b7035ca66a1a459f21160f1d5ba7fcb2

Powered by Google App Engine
This is Rietveld 408576698