Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1508303004: Fix the ninja target -> GN label mapping for wtf_unittests, webkit_unit_tests (Closed)

Created:
5 years ago by Dirk Pranke
Modified:
5 years ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the ninja target -> GN label mapping for wtf_unittests, webkit_unit_tests This was causing issues when generating the build files on the bots after flipping the blink bots to GN. TBR=brettw@chromium.org BUG=432959 Committed: https://chromium.googlesource.com/chromium/src/+/1b64ac44a3141224156ea616e6eeb17519f2770b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1b64ac44a3141224156ea616e6eeb17519f2770b Cr-Commit-Position: refs/heads/master@{#364250}
5 years ago (2015-12-10 01:48:52 UTC) #2
Dirk Pranke
5 years ago (2015-12-10 01:49:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b64ac44a3141224156ea616e6eeb17519f2770b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698