Check url path as well as document title to detect formless autofill page

components/autofill/content/renderer/form_autofill_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/form_autofill_util.h"
 
 #include <map>
 #include <set>
 
 #include "base/command_line.h"
@@ skipping 1386 matching lines @@
 bool UnownedCheckoutFormElementsAndFieldSetsToFormData(
     const std::vector<blink::WebElement>& fieldsets,
     const std::vector<blink::WebFormControlElement>& control_elements,
     const blink::WebFormControlElement* element,
     const blink::WebDocument& document,
     ExtractMask extract_mask,
     FormData* form,
     FormFieldData* field) {
   // Only attempt formless Autofill on checkout flows. This avoids the many
   // false positives found on the non-checkout web. See
-  // http://crbug.com/462375. For now this early abort only applies to
-  // English-language pages, because the regex is not translated. Note that
-  // an empty "lang" attribute counts as English. A potential problem is that
-  // this only checks document.title(), but should actually check the main
-  // frame's title. Thus it may make bad decisions for iframes.
+  // http://crbug.com/462375.
   WebElement html_element = document.documentElement();
+
+  // For now this restriction only applies to English-language pages, because
+  // the keywords are not translated. Note that an empty "lang" attribute
+  // counts as English.
   std::string lang;
   if (!html_element.isNull())
     lang = html_element.getAttribute("lang").utf8();
-  if (lang.empty() ||
-      base::StartsWith(lang, "en", base::CompareCase::INSENSITIVE_ASCII)) {
-    std::string title(base::UTF16ToUTF8(base::string16(document.title())));
-    const char* const kKeywords[] = {
-      "payment",
-      "checkout",
-      "address",
-      "delivery",
-      "shipping",
-    };
+  if (!lang.empty() &&
+      !base::StartsWith(lang, "en", base::CompareCase::INSENSITIVE_ASCII)) {
+    return UnownedFormElementsAndFieldSetsToFormData(
+        fieldsets, control_elements, element, document, extract_mask, form,
+        field);
+  }
 
-    bool found = false;
-    for (const auto& keyword : kKeywords) {
-      if (title.find(keyword) != base::string16::npos) {
-        found = true;
-        break;
-      }
+  // A potential problem is that this only checks document.title(), but should
+  // actually check the main frame's title. Thus it may make bad decisions for
+  // iframes.
+  std::string title = base::ToLowerASCII(base::UTF16ToUTF8(base::string16(
+      document.title())));
+
+  // Don't check the path for url's without a standard format path component,
+  // such as data:.
+  std::string path;
+  GURL url(document.url());
+  if (url.IsStandard())
+    path = base::ToLowerASCII(url.path());
+
+  const char* const kKeywords[] = {
+    "payment",
+    "checkout",
+    "address",
+    "delivery",
+    "shipping",
+  };
+
+  bool found = false;
+  for (const auto& keyword : kKeywords) {
+    if (title.find(keyword) != base::string16::npos ||

[Evan Stade, 2015/12/10 19:34:00]

I think you should use std::find_if with base::LowerCaseEqualsASCII

[Joe Mason, 2015/12/10 20:06:58]

That would be less efficient since we need to convert title each time through
the loop. It probably doesn't make much difference, but what's the benefit?

[Evan Stade, 2015/12/10 21:21:11]

You're right, probably not a huge difference, but fewer lines of code and no
utf16->utf8 conversion (which is much more costly than Z->z).

[Joe Mason, 2015/12/11 20:41:43]

Done.

+        path.find(keyword) != base::string16::npos) {
+      found = true;
+      break;
     }
-    if (!found)
-      return false;
   }
+  if (!found)
+    return false;
 
   return UnownedFormElementsAndFieldSetsToFormData(
       fieldsets, control_elements, element, document, extract_mask, form,
       field);
 }
 
 bool UnownedPasswordFormElementsAndFieldSetsToFormData(
     const std::vector<blink::WebElement>& fieldsets,
     const std::vector<blink::WebFormControlElement>& control_elements,
     const blink::WebFormControlElement* element,
@@ skipping 198 matching lines @@
     // Zero selection start is for password manager, which can show usernames
     // that do not begin with the user input value.
     selection_start = (offset == base::string16::npos) ? 0 : offset;
   }
 
   input_element->setSelectionRange(selection_start, suggestion.length());
 }
 
 }  // namespace form_util
 }  // namespace autofill