Simplify Go's Mojom Type Generator

mojo/public/tools/bindings/run_code_generators.py

Index: mojo/public/tools/bindings/run_code_generators.py
diff --git a/mojo/public/tools/bindings/run_code_generators.py b/mojo/public/tools/bindings/run_code_generators.py
index 46ddfcb10fb321854d4faf5e43da68a2905ee2ee..31331fbca335759be3245f5c271c665cdaca4b8b 100755
--- a/mojo/public/tools/bindings/run_code_generators.py
+++ b/mojo/public/tools/bindings/run_code_generators.py
@@ -39,6 +39,13 @@ def _ParseCLIArgs():
                       help="comma-separated list of generators")
   parser.add_argument("-d", "--depth", dest="depth", default=".",
                       help="relative path to the root of the source tree.")
+  parser.add_argument("--generate_type_info", dest="generate_type_info",

[azani, 2015/12/21 22:28:37]

Make the argument name "generate-type-info" to match the other args.

[alexfandrianto, 2015/12/21 23:50:11]

Done.

+                      action="store_true",
+                      help="do not generate mojom type descriptors")
+  parser.add_argument("--no_generate_type_info", dest="generate_type_info",
+                      action="store_false",
+                      help="do not generate mojom type descriptors")
+  parser.set_defaults(generate_type_info=True)

[azani, 2015/12/21 22:28:37]

Just use the default param to add_argument. Also, don't we want to default to
False?

[alexfandrianto, 2015/12/21 23:50:11]

The default is true so that the test(s) will compile.

action="store_true" and "store_false" already have the opposite as defaults. I
like this way more since it's clearer what it will end up being. Further, it is
also clearer how to change it in the future.

[azani, 2016/01/04 22:20:44]

I understand your point regarding tests, but if we set it to true by default,
this means type info will be generated for everybody. As long as this is just
something that happens with go bindings, that's not a big deal because you're
the primary users. But the Dart bindings are in use by a lot of people and they
shouldn't have to do anything to avoid generating extraneous code. So I'm ok
with this for now, but we need to switch the default to False before your dart
bindings change is landed.

 
   return parser.parse_known_args()
 
@@ -162,6 +169,8 @@ def main():
         prefix = '--' + generator_module.GENERATOR_PREFIX + '_'
         filtered_args = [arg for arg in remaining_args
                          if arg.startswith(prefix)]
+      if args.generate_type_info:
+        filtered_args.append("--generate_type_info")
 
       generator.GenerateFiles(filtered_args)