Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 1508253002: [ios] Update SSL status if URL was changed without document change. (Closed)

Created:
5 years ago by Eugene But (OOO till 7-30)
Modified:
5 years ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews, stuartmorgan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Update SSL status if URL was changed without document change. URL change without document change may create a new entry in NavigationManager, hence SSL status should be updated for it. BUG=562024 Committed: https://crrev.com/2b6af83b6942386f357cf10b70d4d0cf6824180a Cr-Commit-Position: refs/heads/master@{#363856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/web/web_state/ui/crw_wk_web_view_web_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Eugene But (OOO till 7-30)
5 years ago (2015-12-08 23:43:38 UTC) #2
Jackie Quinn
lgtm
5 years ago (2015-12-08 23:44:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508253002/1
5 years ago (2015-12-08 23:49:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 00:46:33 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-09 00:48:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b6af83b6942386f357cf10b70d4d0cf6824180a
Cr-Commit-Position: refs/heads/master@{#363856}

Powered by Google App Engine
This is Rietveld 408576698