Issue 1508243002: XFA: Fix GN build under chromium checkout when no targets specified

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1508243002: XFA: Fix GN build under chromium checkout when no targets specified (Closed)

Created:
5 years ago by Tom Sepez

Modified:
5 years ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

XFA: Fix GN build under chromium checkout when no targets specified Hide the existence of the xfa libraries from GN when the feature is not enabled. GN may try to build them otherwise when trying to build "everything" even though nothing depends on them. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b36747d4348c10f85b753669750f0767797ddbe2

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+691 lines, -689 lines)			Patch
	M	BUILD.gn	View		1 chunk	+691 lines, -689 lines	0 comments	Download

Total messages: 5 (2 generated)

Lei Zhang

lgtm I'm assuming everything has been indented, but the diff just looks funny.

5 years ago (2015-12-08 23:46:16 UTC) #3

Tom Sepez

5 years ago (2015-12-08 23:49:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b36747d4348c10f85b753669750f0767797ddbe2 (presubmit successful).